Hi Peter,
On 12/2/20 10:16 AM, Peter Ji wrote:
You have a number of easy to fix lintian tags. I'd recommend to fix them.>Thanks for your review, Lintian tags have been fixed in the latest upload.
That's great news! The first time around, I only looked at
mentors.debian.net QA information. Now is time for a bit more in-depth
review. Don't hesitate to ask questions, I'll happy to answer them :)
Note: Read through the entire mail, I have a couple of useful links in
the end.
- debian/changelog:
It's looking a bit thin. Each and every changes from one version to
another must be documented in this file. For instance you've added the
VCS fields, the Homepage, the Require-Root-Rules in debian/control. That
must be documented along side with every modification you've made.
Don't hesitate to run a spell checker on the changelog once done. You
have a syntax error with the comma.
- debian/control:
You can bump the policy to 4.5.1, it was released a couple of days
ago. To see if you have any additional modification see the checklist [1]
The Homepage field is an URL to upstream sources [2], not the
packaging one.
You shouldn't need Require-Root-Rule to build that software. I suppose
it's required because you explicitly set the owner/group when installing
the program. Drop that and the R-R-R.
Once again the spell checking indicates a syntax error. Your "for" is
preceded by a dot.
- debian/copyright:
The Source, like the Homepage field of debian/control also refers to
the upstream source.
You are missing a block for the debian/* files. You should list every
authors present in debian/changelog, including yourself.
You are missing an entry for strsep.c, which license and copyright
holder differs from other sources (man licensecheck).
- debian/NMU-Disclaimer:
NMU is quite well defined in the developer reference [3]. Unless you
plan on following those outdated guidelines, you can safely drop this file.
- debian/patches:
Your patch name and description doesn't match the content of the
patch. You are patching different files for different reason and a
separate patch file is needed for each one of them.
Don't update upstream CHANGES with Debian changelog information. Both
will be installed under /usr/share/doc/<pkg> and content should be
respectively separated.
Don't patch the Makefile with anything related to the Debian
packaging. That should be done in debian/rules.
You have a trailing whitespace line 108 of the patch file and the
"for" have that previous dot as well.
Creating a README.Debian with sole content the description of the
package is useless. Please remove it. (also the file should have been
wrap to 80 colons).
- debian/rules:
You switched to using dh, which is very good, but you are not using
any of the dh helper files. Please have a look at the Debian New
Maintainer Guide [4] to help you move all the content of that file to
debian/{install,manpage,clean,...}. As a thumb rule, if you have any
target not starting by 'execute_{before,after}_dh_' or 'override_dh',
you are not finished with the dh conversion.
- debian/watch:
The watch file should monitor upstream release [2], not the packaging
one.
--- I know the list looks long but believe me, it's actually quite feasible :) You can have a look at dhcping packaging [5]. It's a very similar package, from the same upstream, that I converted a couple of weeks ago. Do you know about Debian's Gitlab [6]? While hosting the packaging source anywhere public is actually quite alright, having it on salsa does bring out a couple advantages: - you can create the repository under the debian/ namespace. This will ease collaborative maintenance by any Debian Developer. (Note that you will need to ask the repository creation on debian-mentors@lists.debian.org) - you have access to a nice CI [7] pipeline doing all sort of QA stuff on you package. - it's open-source! As opposed to github :)[1]: https://www.debian.org/doc/debian-policy/upgrading-checklist.html#version-4-5-1
[2]: http://www.mavetju.org/unix/general.php [3]: https://www.debian.org/doc/manuals/developers-reference/ [4]: https://www.debian.org/doc/manuals/maint-guide/ [5]: https://salsa.debian.org/debian/dhcping [6]: https://salsa.debian.org [7]: https://salsa.debian.org/salsa-ci-team/pipeline -- Baptiste Beauplat - lyknode
OpenPGP_signature
Description: OpenPGP digital signature
