Hello Tobias, thanks a lot for this valuable review!
I did my best to update the packages. It's uploaded to mentors: https://mentors.debian.net/package/zipios++/ Please note that the upstream applied some of my patches and they released a new version (2.2.6). I've updated the package with this new release. Comments inline below: > So, yes, sourceful upload of all r-depends it will be… And you > likely will need > to provide patches. (Luckily, those r-depends are just two: freecad > and enigma) > I've forked freecad and enigma in my salsa account and I'm working on patches. > - On the dev package: > It should not Conflict/Replaces, It should be Breaks/Replaces. Done > - On the library package: > be a need for the Conflict/Replace, not even a Breaks/Replaces. Done > - On the docs package: > This is a classic "package renaming" situation explained here: > https://wiki.debian.org/RenamingPackages. > So you will need a transistional package here as well. > Or not renaming the -doc package. I've added a transitional package libzipios++-doc that depends on the new one. > d/docs: > - don't install README.md > - NEWS should be installed as upstream changelog (see > dh_installchangelogs) Done > d/rules + d/control: > - It looks like as your rules already supports building docs in > build-indep. > Please see if you can move doxygen / graphviz B-D to Build-Depends- > Indep. Done > - The docs package has references to the old package: References removed. > BTW, it is _NOT_ recommended to replace the jsquery from doxygen. > read /usr/share/doc/doxygen/README.jquery. No more replace, thanks for the documentation pointer. > - The dev package has the following files, which shoudln't be there: > drwxr-xr-x root/root 0 2020-03-07 14:08 > ./usr/share/doc/libzipios-doc/ > -rw-r--r-- root/root 1654 2019-08-17 00:13 > ./usr/share/doc/libzipios-doc/NEWS.gz > -rw-r--r-- root/root 2352 2019-08-17 00:13 > ./usr/share/doc/libzipios-doc/README.md.gz Files removed. > - The dev package isntalls the man pages. Shouldn't they go to the > -doc package? Moved manpages to libzipios-doc.manpages > - d/rules: > What was the problem with > "# dh_installdocs does not detect the doc main package correctly."? By default, dh_installdocs installs the html documentation under /usr/share/doc/libzipios-dev instead of /usr/share/doc/libzipios-doc inside the libzipios-doc package. I can't figure out why. Any help is welcome! For the moment the only solution I get is to override dh_installdocs. > - There is also dh_doxygen. Perfect tool! It removes md5 and map files, but it does not solve the issue above. > - As per Policy 12.3, the -dev package should Suggest: the -doc > package. Done Thanks, François
signature.asc
Description: This is a digitally signed message part
