On Tue, Sep 29, 2020 at 10:04:16AM +0800, xiao sheng wen (肖盛文) wrote: > Hi, Paul,Tobias, > > Thanks for your review. > > I had uploaded the new package, please help to review again. > > About the upstream: > > I can't find any forks that could be new upstream on Internet.
So, congrats for becoming de-facto* upstream then… ;-) (* due to maintaining a dead-upstream package) > About the "not using autoreconf": > > If use autoreconf, the build will failed: > > automake: warning: autoconf input should be named 'configure.ac', not > 'configure.in' > autoreconf: automake failed with exit status: 1 > dh_autoreconf: error: autoreconf -f -i returned exit code 1 Yes, I see*. But I fear that needs to be debugged and eventually be fixed or it will fly right into your face, at some point of time**… At the very least, config.guess and config.sub needs updating frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz) > The source code is old, it use configure.in. (* The reason for the failure seems to be in configure.in:59; but I did not try anything except commenting out that line; autoreconf suceeds then but configure fails later.) (**I'm not saying you need to fix that right away; maybe you are lucky and it never explodes…) fix-typo-patch -> Please s/type/typo also in the dep3 headers. [nitpick] d/copyright: - You need to have the complete GPL boiler plate in the License text. Note, if you license debian/* GPL-2*+* you need to have an extra section for the different license. (GPL-2 != GPL-2+) - Please also mention the previous maintainers in the debian/* section. d/rules [nitpick] - Please wrap the long lines. Please fix d/copyright and possibly also the nitpicks and I will take a look again. -- tobi
