Package: sponsorship-requests
Followup-For: Bug #966382
Control: tags -1 moreinfo
Hello François,
I came accross your RFS and took a look at it. Many thanks for
stepping in and your contributions to Debian!
Sorry that you had to wait that long…
Here are some notes that needs to be addressed before uploading:
- As you are reintroducing the package, please confirm that you have
read and followed [1]
- you need to have an ITP bug and close that in your debian
changelog. (Reintroducing package, Closes: #ITP)
- I see you have already reopened bugs that where closed by the
removal. Good!
[1]
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#reintroducing-packages
- I see you have imported all the previous version to the salsa repo.
Thats good! However, it misses the pristine-tar branch and all
release tags. Did you forget to push them? Otherwise please
re-populate the repo with:
gbp import-dscs --pristine-tar --sign-tags --debsnap photoprint
- There are undocumented changes. Please list all changes to the
packageing in d/control.
- Please document also what you have done when updating to S-V 4.5.0 (I
see at least the Rules-Requires-Root)
- There is a stray d/copyright.old that should be deleted.
- d/copright. Thanks for taking your time to change it to dep5.
Wishlist: (no blockers for upload)
- I don't like private repos on salsa very much. Please consider moving
it to the Debian namespace for collaborative maintaince.
As always, please check those items, update your pacakges and then
remove the moreinfo tag to signal that you're ready for the next round
of reviewing!
--
Cheers,
tobi
