Package: sponsorship-requests Followup-For: Bug #960940 On 5/19/20 12:12 AM, David Kalnischkies wrote: > Hi, > > Disclaimer: Not sponsoring as I am oblivious to init systems of all > kinds, so I don't feel confident reviewing changes in that area. > > (I am not stalking you – I promise! – I just couldn't let that > opportunity pass by after pushing another set of apt resolver changes > triggered by your packages :P)
Thanks you for your review and also for the quick response to bug reports that I have made on apt :) After your review, I've made the following changes; * versioned Breaks+Replaces * upload to experimental instead of unstable * runit-run.postinst: add a newline before inserting the text avoid code duplication * runit-run.postrm: remove newline at the end of the inittab file, but only if more than one is detected > Also, but that is bike shed material: "-run" ? > I don't have a good suggestion, but I think for the uninitiated > -run and -init will be indistinguishable (also: run-it-run, init!). I haven't addressed this: the "-run" suffix is common for runit related packages (and also runit users) and it's used to mark a tiny config package that ships a runit service, for example - getty-run --> runit service for getty - git-daemon-run --> runit service for git daemon - mini-httpd-run --> runit service for mini-httpd So runit-run is for "run runit as a service under another init system" as opposite to runit-init which is for "use runit as full init replacement". I think the uninitiated user can get an idea by reading the package description of runit, runit-init and runit-run. Anyway I'm open to suggestions if someone thinks that the package description is not helping or there is an idea for a better name then "runit-run". I've re-uploaded the package: Info: https://mentors.debian.net/package/runit Download: dget -x https://mentors.debian.net/debian/pool/main/r/runit/runit_2.1.2-37.dsc updated git repo: https://salsa.debian.org/Lorenzo.ru.g-guest/runit/-/tree/release-2.1.2-37 Best Regards, Lorenzo -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.5.9-van (SMP w/4 CPU cores; PREEMPT) Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: runit (via /run/runit.stopit)