On 10/07, David Kalnischkies wrote:
> As far as I looked I have only some minor nitpick comments because
> I like looking at changelogs and get the feeling of understanding what
> happened without investigating too deeply.
Nitpicks, but very valid points nonetheless.
> I think I would prefer "Adopting package" or "Set myself as maintainer"
> or something like that as "Update" can basically mean everything like
> changing your email address, joining a team or whatever.
Fixed.
> > * Update Build-Depends
>
> If there is a good way to summarize what was exactly updated, please say
> so. Version bump? Now build-depending on KDE, GNOME and Qt3? π
I have to admit I wanted to explain a bit more here but given that there were a
bunch of small changes in the same file at the same time I got a bit lazy with
splitting commits and left it as-is. I've now broken the changes for this and
the copyright file down to individual commits, should be much better.
> > * Bump standards version
>
> Which standard? β also there is a new one out by now.
Added the version, and updated it to 4.4.0.
> > * Bump debhelper compat to 12
>
> You could switch to "debhelper-compat (= 12)" in Build-Depends and
> remove the debian/compat file.
Interesting I didn't know about that, it looks handy. I've updated it to use
this format now.
> > * Install release notes in docs
>
> Your are installing them as NEWS: Do you have a deeper reason for doing
> that?
The policy mentions that release notes should be installed as NEWS[1]
"If an upstream release notes file is available, containing a summary of changes
between upstream releases intended for end users of the package and often called
NEWS, it should be accessible as /usr/share/doc/package/NEWS.gz."
> The file contents look like a bit similar to a NEWS.Debian file
> in content, but then upstream name and content also suggest it should
> contain notes for each (major) release β even if 1.4 is missing β which
> would usually be a bit much for NEWS⦠but yeah, that is really just
> personal taste and style I guess. Long story short: mention NEWS.
It would be much if it was displayed during installation indeed but from my
understanding apt-listchanges only shows NEWS.Debian by default. So in my mind
it's fine to have it there for anyone who's interested to read it.
>
> Thanks again for adopting a package and good luck finding a sponsor now
> that unstable is open again!
>
Thank _you_ for taking a look and reviewing.
The new (more descriptive) changelog after this is the following:
[ Francois Marier ]
* Use sensible-browser instead of Firefox in /etc/xdg/dunst/dunstrc
(Closes: #929456)
[ Nikos Tsipinakis ]
* Adopt package (Closes: #930310)
* New upstream version 1.4.1
* Remove cross.patch (applied upstream)
* Refresh patches
* d/control:
- Drop build-dep on libxdg-basedir
- Remove glib version constraint (minimum version no longer in archive)
- Drop build-dep on gtk in favour of gdk-pixbuf
- Add build-dep on dbus daemon and librsvg (required for the test suite)
* Bump standards to 4.4.0
* Install release notes as NEWS in docs
* Bump debhelper compat to 12
Also switch to using debhelper-compat rather than d/compat
* d/copyright:
- Update Source URL
- Add myself to debian/ attributions
- Add missing license for greatest.h
[1]
https://www.debian.org/doc/debian-policy/ch-docs.html#changelog-files-and-release-notes
Best Regards,
Nikos Tsipinakis
