Hi! On Wed, May 29, 2019 at 08:30:50AM +0200, Heiko Schäfer wrote: > an updated package is available at > > https://launchpad.net/~velnias/+archive/ubuntu/sandbox/+sourcefiles/diskfit/2.0.2.6-1~eoan~ppa1/diskfit_2.0.2.6-1~eoan~ppa1.dsc > > Please ignore the '~eoan~ppa1' for the moment, because I build my packages > currently via Ubuntu's Launchpad. 'Eoan' comes closest to 'sid'.
You'll need to update that for the final upload, but during the review that's ok. debian/copyright needs an entry for install-sh which is under the MIT/X11 license. debians/source/options forces xz level 9 compression, which for this size of files is harmful (doesn't improve disk space, and requires a lot of memory on tiny machines). Please just drop these settings -- they should be used only in special cases. debian/control: could you please fill in Homepage/Vcs-*, or at least drop the commented out fields? The long desc really needs to be extended. Even with trying to use the program, I had some trouble finding out what it is for. Also, a man page is vital for a command-line tool. Upstreamish side: I played with the GUI a bit, and it seems to handle selecting a dir badly (which, in my naive understanding, is what most people will try to do). It does nothing until you click "Cancel", in which case it'll add one of previously (not currently) show directories. And then the program doesn't seem to do anything useful. So, if dirs are not supported, the programs shouldn't at least try them. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ I've read an article about how lively happy music boosts ⣾⠁⢰⠒⠀⣿⡁ productivity. You can read it, too, you just need the ⢿⡄⠘⠷⠚⠋⠀ right music while doing so. I recommend Skepticism ⠈⠳⣄⠀⠀⠀⠀ (funeral doom metal).
