On Thu, Dec 6, 2018 at 2:03 PM Brent Clark wrote: > I am looking for a sponsor for my package "clamav-unofficial-sigs": ... > The respective dsc file can be found at: > > https://mentors.debian.net/debian/pool/main/c/clamav-unofficial-sigs/clamav-unofficial-sigs_5.6.2-1.dsc
Sorry for the long delay, here is a review: These things need to be done before any upload: The upstream tarball fetched by uscan (using debian/watch) needs to be identical to the one you upload to mentors, the one on mentors currently has both missing files and additional files. If any changes are needed to upstream files, they should be represented as patches in debian/patches/ (or possibly other files in debian/). I generally don't use git for packaging but I hear that there are tools that can generate those patches from git commits. About the manual page, cron job and logrotate config, there is an upstream bug that means that `./clamav-unofficial-sigs.sh --config somedir/ --information` doesn't work as it always checks /etc/clamav-unofficial-sigs instead. If it worked, then you could have asked the script to install the files at package build time. A workaround for this bug would be to extract the snippets at build time instead using sed. Unfortunately that isn't feasible since the snippets in the script are only templates and the full output gets created dynamically. Since the fix for this bug is a one-liner, I think it would be best to include the change, since it allows creation of the files at build time and also fixes a bug that users might run into. Place the following line just before the second time that the config_files array is set. config_dir="$custom_config" The upgrade from the old version needs to be checked (with piuparts) to check that it works, that conffiles are handled correctly and that the package still works afterwards. These things would be nice to fix at some point: The second and third stansas of debian/copyright should probably be merged, details in the copyright format guide: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ The package description probably needs to be updated for the new/changed features of the new upstream. The Vcs-* fields in debian/control should point at the packaging VCS rather than the upstream VCS. There are some warnings when I run it on the .changes file after building the package. The new upstream doesn't appear to very active, you might want to offer your assistance or create a new upstream project to maintain the upstream code in, possibly within the ClamAV github organisation: https://github.com/clamav -- bye, pabs https://wiki.debian.org/PaulWise
