Dear Adam, dear all, the following changes have been done:
> There's one laughably small nit: the control file says: > Maintainer: Dominik Klein <dominik.kl...@outlook.com> > while the changelog: > -- Dominik Klein <dominik.kl...@outlook.com> Fri, 21 Dec 2018 10:15:05 +0100 > with different capitalization of the email address. > [...] It'd be best to get this > right before the first upload. changed to uppercase in control file. > The icon still doesn't work for me (xfce). This is finally fixed now. > > The copyright file would be a lot more readable if you placed you and Karl > into a "Files: *" stanza. If two stanzas match the same file, only the > later one applies, allowing overriding a more global match. I missed that one. Changed that, and the copyright file should now be way more readable. > Likewise, the .install file could be made more readable using wildcards. > Of course, this is not mandatory, but would be nice to have. Same as above. kind regards - Dominik Klein Am 23.12.2018 um 02:33 schrieb Adam Borowski: > On Fri, Dec 21, 2018 at 08:45:40PM +0000, Dominik Klein wrote: >> thanks very much for your feedback. >> >> I've filed an ITP under #917027. >> >> Moreover I've >> - changed the icon to a png, since the problem is likely that not all >> window manager are able to display .ico >> - changed changelog to mark for unstable >> - added regexp to track new releases via the watch-file >> - modified the copyright file to clarify for all files who owns the >> copyright and which license >> - The .bin is polyglot opening book. It's format is openly documented, >> e.g. here http://hardy.uhasselt.be/Toga/book_format.html >> >> I also changed the changelog >> https://github.com/asdfjkl/jerry/releases/tag/v3.1.0 to automatically >> close #917027, i.e. if feedback for the ITP is positive and a sponsor >> would come forward, the current package might be suitable for inclusion... > > Awesome. > > There's one laughably small nit: the control file says: > Maintainer: Dominik Klein <dominik.kl...@outlook.com> > while the changelog: > -- Dominik Klein <dominik.kl...@outlook.com> Fri, 21 Dec 2018 10:15:05 > +0100 > with different capitalization of the email address. > > For many mail servers, the user field is case-sentisive, thus tools in > general have to understand it this way. > > Yet while it's just a detail, it would spook at least some of the archive > tools into thinking you're not the maintainer. It'd be best to get this > right before the first upload. > > > Other stuff that would be nice to improve but are not blockers: > > Tthe icon still doesn't work for me (xfce). > > The copyright file would be a lot more readable if you placed you and Karl > into a "Files: *" stanza. If two stanzas match the same file, only the > later one applies, allowing overriding a more global match. > > Also, while missing a copyright holder is an error (not for a reasonable > person, but lawyers are not reasonable, thus the ftpmasters need to be > strict), being too generous is benign. Thus, having both you and Karl for > the majority of files would allow coalescing all those entries into a single > one, leaving nothing but icons, pieces and books. > > Likewise, the .install file could be made more readable using wildcards. > Of course, this is not mandatory, but would be nice to have. > > > Meow! >
