On Thu, Dec 20, 2018 at 01:14:01PM -0800, Felix Lechner wrote: > On Thu, Dec 20, 2018 at 12:10 PM Adam Borowski <kilob...@angband.pl> wrote: > > > > audio_gsm.c:29:11: fatal error: GSM610/gsm.h: No such file or directory > > # include "GSM610/gsm.h" > > Thank you for taking a look. The errors you found are due to confusion > about the include path.
Full results of the rebuilds: asterisk_amd64.build:Status: given-back baresip_amd64.build:Status: successful blender_amd64.build:Status: successful ffmpeg_amd64.build:Status: successful flightgear_amd64.build:Status: successful freerdp2_amd64.build:Status: attempted gmerlin-avdecoder_amd64.build:Status: attempted gnuradio_amd64.build:Status: successful gst-plugins-bad1.0_amd64.build:Status: successful kino_amd64.build:Status: successful linphone_amd64.build:Status: successful mangler_amd64.build:Status: given-back mediastreamer2_amd64.build:Status: attempted mplayer_amd64.build:Status: successful pjproject_amd64.build:Status: successful ring_amd64.build:Status: successful rplay_amd64.build:Status: successful sipxtapi_amd64.build:Status: successful sox_amd64.build:Status: successful svxlink_amd64.build:Status: successful swh-lv2_amd64.build:Status: successful swh-plugins_amd64.build:Status: successful twinkle_amd64.build:Status: attempted vlc_amd64.build:Status: successful wine-development_amd64.build:Status: given-back wine_amd64.build:Status: given-back http://ix.io/1wu4 http://ix.io/1wu3 Breakage looks same. > The previous version shipped gsm.h in two locations: It was in > /usr/include, and again in /usr/include/gsm---together with a bunch of > probably private headers that gave rise to #882176. When trying to fix > the latter, I settled for /usr/include/gsm.h since the file appeared > to be the sole header (although the reporting party's patch kept it in > /usr/include/gsm). As a side note, I had seen #include <gsm gsm.h=""> in > a package of mine but thought it was conditional on autoconf; some of > the packages you tested may also look for the header in both places. > Either way, I uploaded a new version to Mentors that again ships the > same file in both locations. Would you please try again? > > If you feel strongly about it, we can also file bugs against packages > that use the library but do not look for the header in your favorite > location. I have no preference. I'm slightly biased towards making a hard break rather than a compat hack that'd linger -- the former is more immediate work but is far cleaner. On the other hand, packages might silently _succeed_ to build while skipping gsm support, and there's little time to find such bugs before Buster's freeze. Do you happen to know what upstream does? Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Ivan was a worldly man: born in St. Petersburg, raised in ⢿⡄⠘⠷⠚⠋⠀ Petrograd, lived most of his life in Leningrad, then returned ⠈⠳⣄⠀⠀⠀⠀ to the city of his birth to die.
