[2018-12-19 15:41] Adrian Nuta <adrian.n...@manticoresearch.com> > > * your documentation should be in /usr/share/doc/manticore, not MANTICORE > > > removed that folder (not sure why cmake was using uppercased name) > > > * I believe you install not all available documentation. You may want > > to create bin:manticore-doc for it. > > > We don't have a text version of the documentation and it's pretty large. > Not sure how would make sense to include it in package when it's online.
HTML local documentation is fine too. Including it has a lot of sense. It brings convenience -- not everybody has fast (>= 1Mb/sec) access to Internet and privacy -- local documentation do not have trackers and access.log. > * chown manticore:manticore /etc/sphinxsearch is strage. Files in /etc > > > are not meant to be edited by someone, but root. Ideally, you should > > assume /etc is mounted read-only. > > * What are relations with bin:sphinxsearch? Are they co-installable? > > > About these ... there's a big omission I've made: manticore is a > replacement for sphinxsearch > (mantictore is a fork from last OSS version of sphinx, the current > sphinxsearch is some kind of free binary only). I believe in this case you'd better coordinate your work with maintainer of bin:sphinxsearch, Radu Spineanu <r...@debian.org>. He would be much more compenent sponsor in your case. Added him in Cc. > I added Replace and Break in control file. > The reason /etc/sphinxsearch is chowned in case user switch to manticore > (we use different folders for log and data, but kept same config file > path). I foresee issues when user installs manticore, and after that try to install sphixsearch. You definitely need to coordinate. > One question about debian/watch: when checking, is the orig.tar.gz > uploaded on mentors used or the version from watch? Because right now > the upstream release doesn't include many of the fixes (they will be > all on next one) uscan downloads what is written in `debian/watch'. In your case it would be github release. If it is incomplete, they you have to make it complete :)