Hi Mo, Thanks for the info.
> 1. Can we avoid shipping with embedded code copy[1] of lua, termbox and > uthash? . lua 5.3 and uthash are already in the archive. termbox needs > to be packaged. Yes, I can make Lua and uthash package deps instead of embedding them. Is it ok to embed termbox for now, or should we consider that a blocker? There is a packaging branch in the main repo by the way: https://github.com/adsr/mle/tree/debian Thanks for the tip about the "Recommends" field. I will add optional runtime deps there. Adam On Fri, 12 Oct 2018 04:50:12 +0000 Mo Zhou <lu...@debian.org> wrote: > Hi Adam, > > Thanks for this package, the copyright file looks good to me. > However there are still a couple of problems: > > 1. Can we avoid shipping with embedded code copy[1] of lua, termbox and > uthash? . lua 5.3 and uthash are already in the archive. termbox needs > to be packaged. > > 2. I'd recommend you to create a packaging repo so that the others can > track the changes about packaging with git. Since you are also the > upstream author, it's fine if you set the source format as > "3.0 (native)" and push the debian directory to the upstream git repo. > A separate git repo following e.g. the gbp-buildpackage workflow is > also acceptable. No packaging repo is fine too but not encouraged. > > 3. External tools such as fzf can be leveraged by mle to enhance > features. That means those packages should be listed in the > "Recommends" or "Suggests" fields. > > Best. > > [1] https://wiki.debian.org/EmbeddedCodeCopies > > On Thu, Oct 11, 2018 at 08:04:33PM -0400, Adam Saponara wrote: > > Package: sponsorship-requests > > Severity: wishlist > > > > Dear mentors, > > > > I am looking for a sponsor for my package "mle": > > > > Package name : mle > > Version : 1.2-1 > > Upstream Author : Adam Saponara <a...@php.net> > > URL : https://github.com/adsr/mle > > License : Apache, Expat, BSD-1-clause > > Section : editors > > > > It builds those binary packages: > > > > mle - flexible terminal-based text editor (C) > > > > To access further information about this package, please visit the > > following URL: > > > > https://mentors.debian.net/package/mle > > > > Alternatively, one can download the package with dget using this command: > > > > dget -x https://mentors.debian.net/debian/pool/main/m/mle/mle_1.2-1.dsc > > > > More information about hello can be obtained from > > https://github.com/adsr/mle. > > > > Changes since the last upload: - > > > > Regards, > > > > Adam > > >
