Hi Yangfl,
On Tue, May 22, 2018 at 08:43:07PM +0800, Yangfl wrote:
> 2018-05-20 19:50 GMT+08:00 Lumin <cdlumin...@gmail.com>:
> > control: tag -1 +moreinfo
> >
> > On Fri, May 04, 2018 at 10:37:27AM +0800, Yangfl wrote:
> >> control: tag -1 - moreinfo
> >>
> >> Reuploaded.
> >
> > Please fix your packaging repo first:
> >
> > https://salsa.debian.org/chinese-team/netctl/network/master
> >
> > The stuff in the master branch is identical to the upstream branch.
> > "debian" directory is contained in no branch. This is an error.
> > "upstream" version keeps a copy of untouched upstream source.
> > "master" branch is typically holding the debian/ folder on the top
> > of the "upstream" branch.
> >
> > You should fix the packaging repo, or I won't know what on earth
> > the changes are.
> >
> > After fixing the packaging repo, please fix the problematic
> > installation path:
> >
> > -rw-r--r-- root/root 353 2018-04-20 10:54 ./netctl-ifplugd@.service
> > -rw-r--r-- root/root 284 2018-04-20 10:54 ./netctl-sleep.service
> > -rw-r--r-- root/root 289 2018-04-20 10:54
> > ./netctl-wait-online.service
> > -rw-r--r-- root/root 260 2018-04-20 10:54 ./netctl.service
> > -rw-r--r-- root/root 316 2018-04-20 10:54 ./netctl@.service
> > drwxr-xr-x root/root 0 2018-04-20 10:54 ./usr/
> >
> > Run "debc" for a quick content check after building an package.
> > Run "lintian -EviI --pedantic" and fix those lintian Warnings.
> >
> > Please don't remove the moreinfo tag if you are not sure your
> > package is totally correct.
> >
> > Thank you for the update, and please ping me when you are ready
> > for the next round of review.
>
> Done.
The package doesn't build with the source package from pristine-tar.
The packaging repo still looks incorrect. The packaging branch is
directly built on top of the upstream master branch. Personally I
recommend to create packaging repo like this:
1. create empty git repo
2. download upstream source tarball, or »git archive« from upstream
git repo.
3. »gbp import-orig --pristine-tar upstream.orig.tar.gz«
4. Upstream branch keeps a copy of upstream source, instead of
a copy of the upstream git commits. Pristine-tar branch keeps
the tarball used to build upstream source and help keep the
package reproducible. Master branch is usually where your
packaging work goes.
5. write a watch [See uscan(1)] file if possible.
6. When the next upstream release is available, download it via uscan
or do it manually, and do gbp import-orig.
Anyway let's talk about the problems to be solved:
1. Incorrect installation path
W: netctl: file-in-unusual-dir netctl-ifplugd@.service
./netctl-auto@.service
./netctl-ifplugd@.service
./netctl-sleep.service
./netctl-wait-online.service
./netctl.service
./netctl@.service
2. Incomplete copyright information
I quickly scanned all the files, there are far more than one
contributors in the upstream project.
At least you should copy all the authors from AUTHORS to
debian/copyright, and append a wildcard author to the list:
20XX Netctl contributors
3. rules:
Why override the "build" and "dh_install" target?
This patch also fixes problem 1:
```
diff --git a/debian/rules b/debian/rules
index 6aca0c9..3c7c9c6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,13 +5,11 @@
%:
dh $@
-build:
- # no build target; `make install' during build stage causes error
+override_dh_auto_build:
+ true
override_dh_auto_install:
+make SHELL=/bin/bash .SHELLFLAGS="-O extglob -c" PREFIX=/usr
DESTDIR="$(CURDIR)/debian/netctl" install
-
-override_dh_install:
mv debian/netctl/etc/netctl/examples debian/netctl/usr/share/netctl/
mkdir debian/netctl/etc/ifplugd/action.d/
mv debian/netctl/etc/ifplugd/netctl.action
debian/netctl/etc/ifplugd/action.d/netctl
```
Please fix these issues.
