On Tuesday, April 17 2018, Joel Cross wrote: > Dear mentors, > > I am looking for a sponsor for my package "python-base58" > > * Package name : python-base58 > Version : 0.2.5-1 > Upstream Author : David Keijser <keij...@gmail.com> > * URL : https://github.com/keis/base58 > * License : MIT > Section : python > > It builds those binary packages: > > python3-base58 - base58 encode/decode for Python > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/python-base58 > > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/p/python-base58/python- > base58_0.2.5-1.dsc > > More information about base58 can be obtained from > https://github.com/keis/base58/.
Hey Joel, Thanks for updating the package and addressing some of the comments I've made regarding your other Python packages. I have a couple more comments, and then we should be good to go. The first comment is that your d/changelog is not correct. Since there's been no initial release, you can't actually have two entries there. What you must do instead is update the first entry's version and date, and that's it. The second comment I have is about how you split the package. IIUC, this package is intended to be used as a library or as a tool (binary), which means it's better to create a package specific for the binary tool. So you'd end up with: - python3-base58 - base58 This is actually the same problem I had while packaging python-bugzilla: https://tracker.debian.org/pkg/python-bugzilla https://sources.debian.org/src/python-bugzilla/2.1.0-1/debian/control/ As a side note, I personally don't like the idea of writing the manpage using an intermediate tool like ronn, because this means you have to Build-Depend on ruby-ronn, which depends on ruby and a bunch of other packages, which in the end increases the build time and demands more disk space, but I'm OK if you want to leave it as is (it's a personal preference after all, not a policy). I also suggest you contribute the manpage to the upstream project; I'm sure they'll like it. Other than that, the package looks good and should be ready for upload after you make these changes. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
signature.asc
Description: PGP signature
