On Sun, Mar 18, 2018 at 03:40:17PM +0800, Yangfl wrote: > * Package name : deepin-terminal > Version : 2.9.2-1
> It builds those binary packages: > > deepin-terminal - Deepin terminal emulator application > dget -x > https://mentors.debian.net/debian/pool/main/d/deepin-terminal/deepin-terminal_2.9.2-1.dsc Hi! Great to see a new terminal in. However, there's a lot of problems with this upload. First, it FTBFSes unless you apply the following patch: --- deepin-terminal-2.9.2/debian/control 2018-03-18 05:06:02.000000000 +0100 +++ deepin-terminal-2.9.2/debian/control 2018-03-18 05:06:02.000000000 +0100 @@ -12,6 +12,7 @@ libpcre2-dev (>= 10.21), libgtk-3-dev (>= 3.20), libgnutls28-dev (>= 3.2.7), + libvte-2.91-dev, libxml2-utils, gobject-introspection (>= 0.9.12-4~), libgirepository1.0-dev (>= 0.9.12), Lots of assets have incorrect paths: Got error when load css: <broken file>:1:0Failed to import: Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/style.css: No such file or directory create_image_surface: tab_close_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_normal.svg: No such file or directory create_image_surface: tab_close_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_hover.svg: No such file or directory create_image_surface: tab_close_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_press.svg: No such file or directory create_image_surface: tab_add_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_normal.svg: No such file or directory create_image_surface: tab_add_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_hover.svg: No such file or directory create_image_surface: tab_add_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_press.svg: No such file or directory create_image_surface: tab_add_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_normal.svg: No such file or directory create_image_surface: tab_add_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_hover.svg: No such file or directory create_image_surface: tab_add_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_press.svg: No such file or directory Failed to open file '/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/deepin-terminal.svg': No such file or directorycreate_image_surface: window_menu_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_normal.svg: No such file or directory create_image_surface: window_menu_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_hover.svg: No such file or directory create_image_surface: window_menu_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_press.svg: No such file or directory create_image_surface: window_menu_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_normal.svg: No such file or directory create_image_surface: window_menu_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_hover.svg: No such file or directory create_image_surface: window_menu_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_press.svg: No such file or directory create_image_surface: window_min_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_normal.svg: No such file or directory create_image_surface: window_min_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_hover.svg: No such file or directory create_image_surface: window_min_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_dark_press.svg: No such file or directory create_image_surface: window_min_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_normal.svg: No such file or directory create_image_surface: window_min_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_hover.svg: No such file or directory create_image_surface: window_min_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_min_light_press.svg: No such file or directory create_image_surface: window_max_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_normal.svg: No such file or directory create_image_surface: window_max_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_hover.svg: No such file or directory create_image_surface: window_max_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_dark_press.svg: No such file or directory create_image_surface: window_max_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_normal.svg: No such file or directory create_image_surface: window_max_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_hover.svg: No such file or directory create_image_surface: window_max_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_max_light_press.svg: No such file or directory create_image_surface: window_unmax_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_normal.svg: No such file or directory create_image_surface: window_unmax_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_hover.svg: No such file or directory create_image_surface: window_unmax_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_dark_press.svg: No such file or directory create_image_surface: window_unmax_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_normal.svg: No such file or directory create_image_surface: window_unmax_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_hover.svg: No such file or directory create_image_surface: window_unmax_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_unmax_light_press.svg: No such file or directory create_image_surface: window_close_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_normal.svg: No such file or directory create_image_surface: window_close_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_hover.svg: No such file or directory create_image_surface: window_close_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_dark_press.svg: No such file or directory create_image_surface: window_close_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_normal.svg: No such file or directory create_image_surface: window_close_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_hover.svg: No such file or directory create_image_surface: window_close_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_close_light_press.svg: No such file or directory create_image_surface: quit_fullscreen_dark_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_normal.svg: No such file or directory create_image_surface: quit_fullscreen_dark_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_hover.svg: No such file or directory create_image_surface: quit_fullscreen_dark_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_dark_press.svg: No such file or directory create_image_surface: quit_fullscreen_light_normal.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_normal.svg: No such file or directory create_image_surface: quit_fullscreen_light_hover.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_hover.svg: No such file or directory create_image_surface: quit_fullscreen_light_press.svg Error opening file /build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/quit_fullscreen_light_press.svg: No such file or directory (I assume broken functionality at runtime is at least partially related to errors from loading the above, thus I'm not commenting on that yet.) The copyright file lacks most licenses and copyright holders. Trivial nitpick: sed -i 's/ , /, /g' debian/deepin-terminal.1 喵! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can. ⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener. ⠈⠳⣄⠀⠀⠀⠀ A master species delegates.
