Argh, was not done yet when I hit send... - d/rules: - the override for dh_autoclean could be replaced by the file d/clean - as you arch all packages: please build those in build-indep. Especially doxygen has a huge dependency chain, so this will take load off the buildds, especially those archs which are not that beefy. (This point is optionally, but I would really appreciate it and it is not that much effort) - d/control - wrap-and-sort(1) would improve readability, especially for reviewing (this is optional) - many versioned build dependencies are already satisfied since oldstable. As thus those old version constraint can be removed, especially as this is a new package. - d/compat newest compat is now at 11
-- tobi On Wed, 07 Mar 2018 19:32:48 +0100 Tobias Frost <t...@debian.org> wrote: > Control: tags -1 moreinfo > > On Tue, 06 Mar 2018 16:24:53 +0100 Gard Spreemann <gspreemann@gmail.c om > > > > Upstream provided a patch that fixes this. I've updated > > > > https://mentors.debian.net/debian/pool/main/g/gudhi/gudhi_2.1.0+df sg > -1.dsc > > Thanks! > > But the lintian stuff I complained about is not completly fixed, there > is even a new tag: > I: gudhi source: quilt-patch-missing-description no-external-doc- > resources.patch > > Please run lintian after every build! Best, include it into pbuilder or > like! Remember "some sponsors are evil and pedantic [1] when running > lintian. > > [1] https://nthykier.wordpress.com/2012/02/23/some-sponsors-are-evil -a > nd-pedantic/ > > Those linitian messages should be fixed before an upload: > (As at least partially already asked for in earlier reviews) > > N: Starting on group gudhi/2.1.0+dfsg-1 > N: Unpacking packages in group gudhi/2.1.0+dfsg-1 > N: ---- > N: Processing changes file gudhi (version 2.1.0+dfsg-1, arch source > amd64 all) ... > N: ---- > N: Processing source package gudhi (version 2.1.0+dfsg-1, arch source) > ... > I: gudhi source: binary-control-field-duplicates-source field "section" > in package gudhui > P: gudhi source: file-contains-trailing-whitespace debian/control (line > 110) > P: gudhi source: package-uses-old-debhelper-compat-version 10 > I: gudhi source: quilt-patch-missing-description no-external-doc- > resources.patch > W: gudhi source: unnecessary-testsuite-autopkgtest-field > N: ---- > N: Processing binary package python3-gudhi (version 2.1.0+dfsg-1, arch > amd64) ... > I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist- > packages/gudhi.cpython-36m-x86_64-linux-gnu.so ment meant > I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist- > packages/gudhi.cpython-36m-x86_64-linux-gnu.so preambule preamble > I: python3-gudhi: spelling-error-in-binary usr/lib/python3/dist- > packages/gudhi.cpython-36m-x86_64-linux-gnu.so choosen chosen > N: ---- > N: Processing binary package libgudhi-examples (version 2.1.0+dfsg-1, > arch all) ... > W: libgudhi-examples: lib-recommends-documentation recommends: > libgudhi-doc > N: ---- > N: Processing binary package libgudhi-doc (version 2.1.0+dfsg-1, arch > all) ... > I: libgudhi-doc: possible-documentation-but-no-doc-base-registration
