Hi Juhani!
On 07/02/18 15:38, Juhani Numminen wrote: > Hi Alec, > > Alec Leamas kirjoitti 04.02.2018 klo 18:32 > >>> Please use up-to-date lintian. It'll give you an error tag and several >>> informational and pedantic tags, some of which are easily dealt with. >> >> I'm using sid, updated as of current?! > > "lintian -EIi --pedantic *.changes" will show the pedantic and info tags > that I mentioned. OK, it's now basically looks OK. The debian-watch-does-not-check-gpg-signature, quilt-patch-missing-description and testsuite-autopkgtest-missing diagnostics looks like false negatives to me (given that the patch is truly trivial and will never be upstreamed) >>> debian/rules: >>> Debhelper has picked Makefile instead of setup.py, so you should add >>> "--buildsystem=pybuild" after the --with arguments. Then you can >> remove override_dh_build, >>> override_dh_auto_install and override_dh_python3 rules, and delete the >> file debian/install. >> >> However, this is on purpose. I control upstream, and the Makefile >> actually does the right things. Is there anything wrong with this approach? >> >> That said, rules is in a much better shape since the review, cleaned up >> and with a dh_override_missing added. > > Your approach is fine, although you're using "--quiet" while verbose > builds are preferred[1]. Back in 0.2.0 the Makefile didn't contain the > build target and so I thought it was only for pylint etc. hm....although that link is in the autotools context. I'm using the --quiet flag because I missed an error message in the flood of non-silent output. IMHO, if the package contained native, compiled code being verbose makes sense. But I don't really see it here... Perhaps I should implement V=1 support in the upstream Makefile... > Alright. I think debian/py3dist-overrides is left over and can be deleted. Indeed, fixed. Thanks for explanations, much appreciated! New version uploaded to mentors. Cheers! --alec
