Control: tags -1 moreinfo Hi Lubomir,
On Fri, Jan 05, 2018 at 11:20:02AM +0100, Lubomir Rintel wrote: > Control: tags -1 - moreinfo > > On Thu, 04 Jan 2018 19:13:00 +0100 Tobias Frost <t...@debian.org> > wrote: > > Hi, > > > > here's a review: > > - d/changelog is for UNRELEASED. > > (- you should also update the timestamp) > > Changed to sid. Hope that's all right. Usually we write "unstable". Note that dch(1) when invoked with "-r" will do that for you, along with updating the timestamp. (note that dch will throw away it when you do not edit anything in the log, workaround is 'dch -r ""') > > - Optional: Please add a VCS for the packageing. For example you can > > use salsa.debian.org to host it. > > https://salsa.debian.org/lkundrak-guest/ioport > > Done. Cool! However, please add the appropiate VCS-* fields to d/control: VCS-Git: https://salsa.debian.org/lkundrak-guest/ioport.git VCS-Browser: https://salsa.debian.org/lkundrak-guest/ioport > > - Did you try to forward the patches to upstream? > > Did so now. Just emailed them privately, because there's no list or bug > tracker. +1 You might want to add a "Forwarded: yes, by email" to the dep-3 header of the patches to document that. > > > > It's a pitty that it was "UNRELEASED..." This is the only showstopper > > in the package and the other thinfs would have been fixable in a > later > > releases... > > > > Please iterate and then remove the moreinfo tag... > > Thank you for your review. The updated package is available here: > https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-3.dsc > One small thing: Please enable hardening. You can add this line to the top of d/rules to do the job: export DEB_BUILD_MAINT_OPTIONS = hardening=+all See for details: https://wiki.debian.org/Hardening Sorry for the addtional stuff, but I guess we're close for an upload! Ping me when ready! -- tobi > Lubo >
