Control: tags -1 moreinfo Hi Julien,
another review: - d/changelog: Initial packaging has only one changelog entry, closing the ITP bug. Delete the others. - your tiny library... Please either package it as a real library package. You say in the linitian override that this lib is probably not useful for others (IOW private library), but the rest of the packaging assumes somehow a public library (the -dev pacakge, the symbol files...) So please either private or public... (IMHO the library could be useful for others, so I would go for a libkeyleds package) - Additionally having the binary in the same package as the library will make a multi-arch compatible package impossible - Standard-Version needs to be updated. 3.9.8 is quite old. - d/compat should also be updated - please add a VCS-browser and -Git field in d/control - (optional: please consider moving the packaging repository to a Debian service, e.g salsa.d.o; though salsa is currently in beta, so this can be later.) - the section Files: debian/* in d/copyright is redundant and can be removed (already included in the Files: * section) - lintian: N: Processing changes file keyleds (version 0.5.0-1, arch source amd64) ... N: ---- N: Processing source package keyleds (version 0.5.0-1, arch source) ... P: keyleds source: file-contains-trailing-whitespace debian/rules (line 7) P: keyleds source: package-uses-old-debhelper-compat-version 9 W: keyleds source: out-of-date-standards-version 3.9.8 (current is 4.1.3) N: ---- N: Processing binary package keyleds-dev (version 0.5.0-1, arch amd64) ... I: keyleds-dev: unused-override no-upstream-changelog N: ---- N: Processing binary package keyleds-dbgsym (version 0.5.0-1, arch amd64) ... N: ---- N: Processing binary package keyleds (version 0.5.0-1, arch amd64) ... I: keyleds: hardening-no-fortify-functions usr/bin/keyledsd N: We package the shared library with the main program as it is really tiny, N: and very unlikely one would be useful without the other. O: keyleds: package-name-doesnt-match-sonames libkeyleds1 I: keyleds: spelling-error-in-manpage usr/share/man/man1/keyledsd.1.gz overriden overridden E: keyleds: udev-rule-unreadable lib/udev/rules.d/70-logitech- hidpp.rules - You install some softlinks in d/rules. Can you explain the purpose? - maybe also run check-all-the-things. As usual, please remove the moreinfo tag once you're ready for another round of review! -- tobi
