Hi Denys, On Wed, Nov 22, 2017 at 04:08:05AM +0000, Denys Berkovskyy wrote: > I am looking for a sponsor for my package "dmg2img"
Excellent, thanks for taking care of this!
> Changes since the last upload:
> * New upstream version 1.6.6 (Closes: #778827)
> * New upstream version 1.6.7
> * Fix FTCBFS: Let cdbs' makefile.mk pass cross compilers. (Closes: #864511)
> * Update patches
> * Update debhelper compatibility level to v10
> * Bump standards version to 4.1.1 (No changes required)
> * Fix homepage URL, remove obsolete URLs
> * Update debian/copyright file
> * Fix typo in packet description
> * New maintainer (Closes: #881838)
I have a few review comments...
In the changelog, I don’t think there’s much point in repeating “New
upstream version”. I also prefer distinguishing close reasons in
detail: so “New upstream version” would close a bug requesting a new
upstream version, but not bugs which happen to be fixed in the
upstream release. This would result in something like
* New upstream release:
- fixes a crash on invalid block signatures (Closes: #778827)
While you’re at it, could you check to see whether the other crashing
bugs are fixed? I think some of them might be...
It would be nice too to see whether bindnow and fortify can be enabled
(unless those are false positives in Lintian’s output).
Regards,
Stephen
signature.asc
Description: PGP signature
