Hi Diane, Thank you very much for the review :-)
On Tue, Sep 05, 2017 at 10:11:59PM -0700, Diane Trout wrote: > > * Lintian warnings are just missing gpg signature and upstream > changelog Neither of these is provided upstream. > I had trouble running 5.4.0 tests even outside of the builder chroot, I > tried the newer upstream 5.4.1 and all but one of those tests ran > successfully in a download of the project. My patch to set ffip-project-root should make it work in a chroot, and 5/5 tests pass on my system both running (unpatched source) tests/test.sh, (patched source) dpkg-buildpackage, and gbp. Would you please attach a build log, because I'm very surprised to hear that a test is failing. Sincerely, Nicholas
signature.asc
Description: PGP signature
