Dear Gianfranco, Thanks for the review!
On Tue, Feb 28, 2017 at 7:48 PM, Gianfranco Costamagna <costamagnagianfra...@yahoo.it> wrote: > > lets have a look: > 1) did you forward the patch upstream? sorry, no. upstream hosts in launchpad, which I don't have an account. > 2) why are you disabling tests? my local gbp build (with or without pbuilder) is fine, however two test items fail on debomatic. I already paste the log from debomatic to the patch. > 3) is the package still maintained? I'm not sure. Last upload was 3 years ago, though. I don't use the package myself, but it's a dependency of another package I'm interested in, so I'm just trying to help on this package. > Disabling tests seems bad to me, please investigate the reason for the > failures > and explain them in the patch in case Since I fixed another library dependency issue (Build-Depends on golang-check.v1-dev), how about upload first to experimental without the patch disabling two tests, to see how the test goes on buildd (instead of debomatic)? If the two tests fail also on buildd, we can investigate further. If you agree with things above, I can prepare another upload to mentors. Thanks! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
