Control: tags -1 moreinfo
Hi Kyle,
(sorry, I missed a bit the last review)
d/changelog:
- do not bump version until the first upload is done.
in other words, it should just read, no other entries
gnome-shell-extension-shortcuts (1.0.3-1) unstable; urgency=medium
* Initial Upload (Closes: #847076)
-- Kyle Robbertze <krobber...@gmail.com> Wed, 07 Dec 2016 10:12:14
+0200
- there is an trailing space in d/control line 15
- d/dirs is not needed.
- d/rules: (this is bikeshedding, you do not need to follow) I prefer
to clean via (the file) d/clean not via an override in d/rules.
- src/convenience.js is originally not copyrighted by you, but
by Giovanni Campagna <scampa.giova...@gmail.com> and also under
BSD-3-clause. Please approbiatly attribute copyrights.
(This is a show stopper)
- in the schema description is a typo: pannel.
--
tobi
On Wed, 7 Dec 2016 10:31:04 +0200 Kyle Robbertze <krobber...@gmail.com>
wrote:
>
>
> On 06/12/2016 23:45, Tobias Frost wrote:
> > Hi Kyle,
> >
> > please also open a RFS bug for this..
> Done
> >
> > packaging:
> > - there is a missing Dependency on gnome-shell
> Added
> >
> > upstream:
> > - the version constraint metadata.json looks weird: 3.22.2...
> > shouldn't it be only 3.22 or like? Not sure, please x-check.
(this is
> > also something for the logout button extension)
> Should be just 3.22. Seems the gnome tool to create the extension
> skeleton added the exact version I am using.
> >
>
> Cheers
> Kyle
>
