Hi Jaimos,
Jaimos Skriletz wrote:
> I am looking to update and maintain the latest release of fvwm in
> Debian. I have created a source package for review
Thanks!
> along with have had a short correspondence with the current
> maintainer, sharing my work with him. The current maintainer said he
> no longer uses fvwm and if I'm willing to take responsibility I am
> welcomed to.
>
> I have shared my work with the maintainer but besides that one short
> email, he has not gotten back to me.
Vincent: I assume you are aware of this sponsoring request and are
fine with the adoption of Debian's fvwm package.
I've had a short review of your changes and only found a few minor
nitpicks so far:
> - New features and bug fixes. For a full list between 2.6.5 and 2.6.7
> see /usr/share/doc/fvwm/NEWS.gz
Since the upstream NEWS file is defacto a changelog, it wouldn't be
bad if the upstream NEWS file would be installed as
/usr/share/doc/fvwm/changelog.gz
This can be achieved by removing NEWS from debian/fvwm.docs and adding
the following override to debian/rules:
override_dh_installchangelogs:
dh_installchangelogs NEWS
Would fix the (pedantic-level) lintian warning no-upstream-changelog.
> * Upstream moved from cvs to git. Updated watch file.
Please use https://github.com/fvwmorg/fvwm/releases instead of
https://github.com/fvwmorg/fvwm/tags in debian/watch. (May need some
additional tweaking.) Otherwise you would download a Git snapshot of
the tagged commit instead of the real released tar ball.
Compare:
→ md5sum 2.6.7.tar.gz fvwm_2.6.7.orig.tar.gz fvwm-2.6.7.tar.gz
9fa7c3968a8872a228ce186d5bce8cc1 2.6.7.tar.gz ←
https://github.com/fvwmorg/fvwm/archive/2.6.7.tar.gz
56ab83b0afa211729fce4a4d6fc57e8e fvwm_2.6.7.orig.tar.gz ←
http://fvwmforums.org/fvwm-2.6.7/fvwm_2.6.7.orig.tar.gz
56ab83b0afa211729fce4a4d6fc57e8e fvwm-2.6.7.tar.gz ←
https://github.com/fvwmorg/fvwm/releases/download/2.6.7/fvwm-2.6.7.tar.gz
All the Lintian hardening warnings could be fixed by just adding this
line to debian/rules (e.g. after the DH_VERBOSE line):
export DEB_BUILD_MAINT_OPTIONS=hardening=+all
>From the debdiff between the current and your source package:
%:
- dh $@ --with autoreconf
+ dh $@
Why have you removed "--with autoreconf" while keeping the
Build-Depends on dh-autoreconf? This change is also not mentioned in
the debian/changelog entry.
My suggestion to solve this is to leave debian/rules as it is now,
remove the build-dependency on dh-autoreconf and use debhelper compat
level 10 instead (which implies --with autoreconf and --parallel) --
and mention that in the debian/changelog.
As far as I can see, you can also safely drop the build-dependency on
autotools-dev as its not used directly and debhelper depends on it
(and on dh-autoreconf) nowadays. At least it still builds fine in
pbuilder (without these two build-dependencies, and with debhelper
compat level 10).
Despite those are all rather minor issues, I'd be happy if you could
come up with an updated source package addressing most of these issues
(at least the debian/watch and missing debian/changelog items).
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
