Hi,
On 08/11/2016 18:30, Mattia Rizzolo wrote:
On Tue, Nov 08, 2016 at 06:22:34PM +0100, Julien Puydt wrote:
* d/copyright looks outdated; at least your own copyright is, but please
look over all of it.
+ maybe stop mixing tabs and spaces so irregularly too?
I tried to rework it.
well, it surely has a better look now ;)
Good!
* d/rules:
+ could you instead inject the -D_LARGEFILE_SOURCE by using
dpkg-buildflags' means? (i.e. DEB_CPPFLAGS_MAINT_APPEND variable)
autotools should be able to deal with it correctly even without
passing it at configure time like that.
Well... now you mention it :
(1) it wasn't autotools-based when I made the package, so that might explain
why everything was passed to the "configure" script ;
(2) it's one of the first packages I made, so I might have had no real clue
what I was doing ;
(3) pbuilder says it compiles as well without it!
==> Conclusion: axed!
_LARGEFILE_SOURCE is one of those definition that enables LFS support;
one way to check whether you killed LFS support by it too is to build on
i386 and run lintian with info tags enabled; there is this tag:
https://lintian.debian.org/tags/binary-file-built-without-LFS-support.html
Well, the upload to experimental is to check nothing is broken by my new
patch, but that will also uncover if that change was bad, won't it?
anyway, --enable-shared --disable-static should be free to go too while
you're on it (I'm not sure off-hand about --disable-static, tbh)
I don't want to ship the static lib, so it's good to have the disabling
flag, but indeed the enabling one can go : committed (and pushed, for a
change!).
+ can't that thing be moved over to dh_auto_install instead of
manually calling make?
Well, since the move to autotools, I don't think that is necessary : axed!
And pbuilder is still happy.
by that you also removed the thing that was deleting the *.la, btw.
As far as I remember, upstream's hand-made configure+Makefile.in called
ldconfig by hand, and installed everything -- that's why I had to remove
things by hand afterwards. The move to autotools produces a better
'install' target : the *.la files don't get shipped needlessly
(something dpkg-deb -c confirms).
Years-old cruft...
Snark on #debian-science
