control: owner -1 !
control: tags -1 moreinfo

Hi, lets review:


1) missing copyrights:

+ * Copyright (c) 2015 Antoine Calando <acala...@free.fr> (displaying 
Ctrl-characters and ascii for hex)
+ * Copyright (C) 2013 Preet Desai <preet.de...@gmail.com> (code to send files 
ported to Qt5 for the original CuteCom
+ *                                                          from 
https://github.com/preet/cutecom-qt5)

and many more
+ * Copyright (c) 2015 Antoine Calando <acala...@free.fr> (improvements added 
to original CuteCom)


2) missing licenses
//creativecommons.org/licenses/by-sa/2.0/
GPL v2
and maybe more.

3) missing license text in copyright file (I'm not sure this is source of 
troubles, but the reduced GPL text is nice to
have)

4) please convert to new dh calls, it should be trivial to do, since the 
packaging is already nice

e.g.
echo cutecom.1 > debian/manpages

cd build && cmake -DCMAKE_INSTALL_PREFIX=$(CURDIR)/debian/cutecom/usr \
-DCMAKE_CXX_FLAGS="$(CFLAGS)" -DCMAKE_C_FLAGS="$(CFLAGS)" \
-DCMAKE_EXE_LINKER_FLAGS="-Wl,-z,defs" -DCMAKE_BUILD_TYPE=RelWithDebInfo ../

this seems mostly useless, with the default dh call it should already be mostly 
handled

dh_installchangelogs Changelog


IIRC this is automatically installed
(also, compat level 10 please, it should inject build flags automatically)

if the auto rule doesn't work, it is because there is an useless "configure" 
file

%:
dh $@



so you can remove it
echo configure > debian/clean

or specify the build system
dh $@ --buildsystem=cmake

5) I would drop the cmake version constraint, it seems useless, also the qt one

6) debian/README.sources <-- please remove

other stuff seems good to me!

thanks

G.

Reply via email to