Hi, >Please review my new package for kpmcore,
ok >thanks for any tips or advice! using mentors would be so appreciated review: 1) grep copyright . -Ri missing copyrights 2) usr/lib/*/libkpmcore.so.2* usr/lib/*/libkpmcore.so.3 why are you installing both SONAMEs? 3) dpkg-gensymbols is sad on i386 dpkg-gensymbols: warning: debian/libkpmcore3/DEBIAN/symbols doesn't match completely debian/libkpmcore3.symbols --- debian/libkpmcore3.symbols (libkpmcore3_2.2.1_i386) +++ dpkg-gensymbolszsmk0k 2016-09-14 10:35:47.181887723 +0000 @@ -28,6 +28,7 @@ _ZN10PartWidget11resizeEventEP12QResizeEvent@Base 2.2.1 _ZN10PartWidget14updateChildrenEv@Base 2.2.1 _ZN10PartWidget16staticMetaObjectE@Base 2.2.1 + _ZN10PartWidget22setFileSystemColorCodeERKSt5arrayI6QColorLj26EE@Base 2.2.1 _ZN10PartWidget22setFileSystemColorCodeERKSt5arrayI6QColorLm26EE@Base 2.2.1 _ZN10PartWidget4initEPK9Partition@Base 2.2.1 _ZN10PartWidgetC1EP7QWidgetPK9Partition@Base 2.2.1 @@ -1182,3 +1183,26 @@ _ZZZNK27SetFileSystemLabelOperation8iconNameEvENKUlvE_clEvE15qstring_literal@Base 2.2.1 _ZZZNK29CreatePartitionTableOperation8iconNameEvENKUlvE_clEvE15qstring_literal@Base 2.2.1 _ZlsR11QTextStreamRK14PartitionTable@Base 2.2.1 +libpmdummybackendplugin.so libkpmcore3 #MINVER# + _ZTI17CoreBackendDevice@Base 2.2.1 + _ZTI20CoreBackendPartition@Base 2.2.1 + _ZTI25CoreBackendPartitionTable@Base 2.2.1 + _ZTS17CoreBackendDevice@Base 2.2.1 + _ZTS20CoreBackendPartition@Base 2.2.1 + _ZTS25CoreBackendPartitionTable@Base 2.2.1 + _ZTV17CoreBackendDevice@Base 2.2.1 + qt_plugin_instance@Base 2.2.1 + qt_plugin_query_metadata@Base 2.2.1 +libpmlibpartedbackendplugin.so libkpmcore3 #MINVER# + _ZTI15ExternalCommand@Base 2.2.1 + _ZTI17CoreBackendDevice@Base 2.2.1 + _ZTI20CoreBackendPartition@Base 2.2.1 + _ZTI25CoreBackendPartitionTable@Base 2.2.1 + _ZTS15ExternalCommand@Base 2.2.1 + _ZTS17CoreBackendDevice@Base 2.2.1 + _ZTS20CoreBackendPartition@Base 2.2.1 + _ZTS25CoreBackendPartitionTable@Base 2.2.1 + _ZTV15ExternalCommand@Base 2.2.1 + _ZTV17CoreBackendDevice@Base 2.2.1 + qt_plugin_instance@Base 2.2.1 + qt_plugin_query_metadata@Base 2.2.1 make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_shlibdeps dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libkpmcore3/usr/lib/i386-linux-gnu/qt5/plugins/libpmdummybackendplugin.so debian/libkpmcore3/usr/lib/i386-linux-gnu/libkpmcore.so.2.2.1 debian/libkpmcore3/usr/lib/i386-linux-gnu/qt5/plugins/libpmlibpartedbackendplugin.so were not linked against libKF5ConfigCore.so.5 (they use none of the library's symbols) G.
