control: tag -1 +moreinfo Dear Jonathon,
On Sun, May 22, 2016 at 05:59:40PM +1000, Jonathon Love wrote: > OK, the package is now available from: > > https://mentors.debian.net/debian/pool/main/f/flatbuffers/flatbuffers_1.3.0-1.dsc I can't sponsor the upload, but I hope this review is useful to you. Since I'm not familiar with java packaging, it would probably be best if you asked the Debian java team to review your package, if you haven't already. My review is just general Debian packaging stuff. 1. It would be great if your source package was available in git, so that I and others can track your revisions in light of reviews. 2. You should add Forwarded: headers to your patches to indicate that they are Debian-specific, or forwarded upstream (couldn't you forward the 1.2.0-SNAPSHOT fix?). 3. Why urgency=low in the changelog? Counterintuitively, that is used to indicate that the package should take longer than usual to migrate from unstable to testing. Is this an unstable upstream release? 4. Did you write debian/flatc.xml by hand? It looks like it was generated from something else. It would be best to perform that generation as part of the package build. 5. Upstream have comprehensive documentation in the docs/ subdir. How about installing it in a flatbuffers-doc binary package? You could then add a doc-base registration. 6. You can also install the readme.md as part of the existing binary packages. 7. I think your copyright file needs to be more specific. For example, php/ByteBuffer.php is copyright 2015 Google, rather than copyright the authors you've listed. 8. There are a lot of generated files in the tests/ subdir. Would it be possible to regenerate them during the package build? I think some of them are already being re-generated, but not all of them. 9. Upstream has a python library, php library, .net library, reflections definition ... there are loads of potentially useful libraries that you're not installing! It would be great to include those in this source package, as their own binary packages. 10. You could install the content of the samples/ subdir into the relevant /usr/share/doc/*/examples directory. That's all for now. -- Sean Whitton
signature.asc
Description: PGP signature
