On Friday, June 17 2016, Niklas Sombert wrote: > Dear mentors, > > I am looking for a sponsor for my package "libterm-animation-perl" > > * Package name : libterm-animation-perl > Version : 2.6-1 > Upstream Author : Kirk Baucom <kbau...@schizoid.com> > * URL : https://metacpan.org/release/Term-Animation > * License : Artistic or GPL-1+ > Section : perl > > It builds those binary packages: > > libterm-animation-perl - ASCII sprite animation framework
Hey Niklas,
Thanks for the package. I have a few comments about it.
1) The Standards-Version should be 3.9.8, and not 3.9.6.
2) On the debian/control file, the last line "This description was
automagically extracted..." could be removed, IMHO.
3) I don't know if you got in touch with the Debian Perl team, but you
probably should.
4) There are some lintian warnings that you should fix. This is what I
get here:
W: libterm-animation-perl: new-package-should-close-itp-bug
This means that you must close the ITP bug in your debian/changelog
entry.
W: libterm-animation-perl: description-contains-dh-make-perl-template
This is about the point that I raised on (2).
W: libterm-animation-perl: manpage-has-errors-from-pod2man
usr/share/man/man3/Term::Animation.3pm.gz:547
W: libterm-animation-perl: manpage-has-errors-from-pod2man
usr/share/man/man3/Term::Animation::Entity.3pm.gz:451
W: libterm-animation-perl: manpage-has-bad-whatis-entry
usr/share/man/man3/Term::Animation::Entity.3pm.gz
These are apparently upstream errors. You should consider fixing them
and contributing the patch back to upstream, IMO.
You can get a detailed list of warnings by running "lintian -Ii" on the
.{deb,asc,changes} files.
I guess that's what I have for now. I'm far from being a Perl expert,
so probably someone with more knowledge about the Debian Perl Policy can
comment more.
Cheers,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
signature.asc
Description: PGP signature
