control: owner -1 ! control: tags -1 moreinfo
Hi, >I am looking for a sponsor for my package "growl-for-linux" lets review: 1) I really don't like a 2k lines long changelog for an initial inclusion. most of the lines are "backport to dist foo" I would just delete them, keeping a public thank to the original maintainer in an entry. (or delete many of them, keeping only significative changes) 2) rules: I was going to complain about a missing --with autoreconf, and then I noticed compat level 10. I never tried it to be honest, but I really like the future, so lets go for it :) what I *really* don't like is: "sed -i -e 's/-fPIE//g' plugins/Makefile" please not, fix autoreconf, not patch autogenerated makefiles. export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-pie should do the trick. BTW Ubuntu and maybe Debian in the future, will have gcc built with default pie, so I guess you need to have an explicit -fno-pie injected, because it needs to be forcibly disabled here, see bug #823869 I you can remove the lintian overrides, and the makeshlibs override (I prefer a lintian warning here, but you are free to leave them) 3) control file: "autotools-dev" <-- is it needed? also please check if dh-autoreconf is needed or not 4) you might want to add some upstream metadata https://wiki.debian.org/UpstreamMetadata Other stuff looks good to me! G.
