control: tags -1 moreinfo Hi,
On Sat, 23 Apr 2016 10:10:28 +0100 Roderick MacKenzie <r.c.i.macken...@googlemail.com> wrote: > Hi Gianfranco, >  I've now used license-reconcile and a bit of copy and paste from > hedgewars to sort out the copyright file.  It's now only complains > about a single .png image - although I think this could be a bug in > license-reconcile as the copyright file looks OK to me. > > I also think my upload_everything_to_gihub.sh script  failed to update > the debian directory.  Hence, I think you were looking at an old > version. > > I've put the new version at: >   https://github.com/roderickmackenzie/gpvdm/releases/tag/gpvdm-4.43 > well, probably having a git branch for this stuff might be better, but meh, lets look (note: I'm out of time, the review is still highly incomplete) debian/control~ <-- remove debian/rules: %: aclocal automake --gnu --add-missing autoconf ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info dh_python2 usr/local/share/gpvdm/ dh $@ --parallel --with python2 NO. please try dh --with autoreconf, and if configure is wrong just override_dh_auto_configure. dh_python2 needs to be called if it needs tweaks in override_dh_python2: not in the default rule. (this will made the above called many and many times even if I didn't try) d/control: try to just use dh-autoreconf build-dependency no autoconf automake autotools-dev (pkg-config might be still needded) I see you have a setup.py, maybe adding an install_requires keyword might make dh_python2 calculate the required dependencies. debian/files <-- remove std-version: 3.9.8 now FTBFS: locutus@Unimatrix04-wily:~/branches/sponsoring/gpvdm ((gpvdm-4.43)) $ ./debian/rules build aclocal aclocal: error: configure.ac:77: file 'make_files.m4' does not exist debian/rules:3: recipe for target 'build' failed make: *** [build] Error 1 thats all for now! cheers, G. > Hope this improves things. > > Many thanks, > Rod > > On Wed, 2016-04-20 at 17:45 +0000, Gianfranco Costamagna wrote: > > Hi, quick answer: > > thanks for the fixes. > > > > > > some quick issues: > > copyright is missing the copyright text > > (look e.g. hedgewars package to see a some licenses to copy-paste) > > > > Depends: is for runtime dependencies, having a -dev here is just > > wrong. > > please let shlibs:Depends do its job, and probably if it fails it is > > because no libraries are currently using the libraries? > > > > > > > > I see you have some dlopens, in that case you might want to runtime > > depends on the runtime libraries > > (and do source uploads at each soname bump) > > > > SIGH. > > > > gedit license: > > (snip) > > it under the terms of the GNU General Public License as published by > > the Free Software Foundation; either version 2 of the License, or > > (at your option) any later version. > > > > (snip) > > > > you seem to be GPL-2+ on your software. > > > > still don't see changes, e.g. source/format and so on > > debian/files is useless. > > > > it is all for now, I'll try again when you fix the above. > > > > cheers, > > > > G. > > > >
signature.asc
Description: OpenPGP digital signature
