control: owner -1 ! control: tags -1 moreinfo Hi, control: "retrieved data" <-- double space std version is 3.9.7 now please run wrap-and-sort please remove quilt from b-d
changelog: one single changelog entry please -rm -f $(CURDIR)/debian/w1retap.1 $(CURDIR)/debian/w1find.1 -> debian/clean might be easier to maintain rules: dh_auto_install is a no-op please remove dh_makeshlibs --noscripts <-- why? remove quilt libw1retap0-odbc.install <-- is that the mysql wrapper? service file: ExecStop=/bin/kill $MAINPID really needed? patches: remove-data-time-macro.patch you can dpkg-parsechangelog and export the changelog date an build date. (this will make the package reproducible I think) question: usually libraries are ship in this way libfooSONAME shipping libfoo.so.SONAME libfoo-dev with an hard dependency on libfooSONAME and a libfoo.so symlink to libfoo.so.SONAME and /usr/include/foo headers files. In your package you are shipping them together not an issue, but do you know what you are doing here? are them useful and being linked outside the package? are them just internal? lots of stuff (systemd script udev rules) should be upstreamed to me check-all-the-things review: codespell --quiet-level=3 cppcheck -j1 --quiet -f . grep -riE 'fixme|todo|hack|xxx' . grep -r '/tmp/' . cheers, G. Il Martedì 19 Gennaio 2016 19:27, Thomas Stewart <tho...@stewarts.org.uk> ha scritto: Dear mentors, I am looking for a sponsor for my package "w1retap": * Package name : w1retap Version : 1.4.4-1 Upstream Author : Jonathan Hudson <jh+w1re...@daria.co.uk> * URL : http://www.zen35309.zen.co.uk/wx/tech.html * License : GPL with some Expat Programming Lang: C Description : Data logger for 1-Wire weather sensors It builds those binary packages: libw1retap0 - Data logger for 1-Wire weather sensors libw1retap0-mongo - Data logger for 1-Wire weather sensors libw1retap0-odbc - Data logger for 1-Wire weather sensors libw1retap0-pgsql - Data logger for 1-Wire weather sensors libw1retap0-sqlite - Data logger for 1-Wire weather sensors w1retap - Data logger for 1-Wire weather sensors To access further information about this package, please visit the following URL: http://mentors.debian.net/package/w1retap Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/w/w1retap/w1retap_1.4.4-1.dsc More information about hello can be obtained from http://www.zen35309.zen.co.uk/wx/tech.html. Changes since the last upload: w1retap (1.4.4-1) unstable; urgency=medium
