Hi Shruti, On 30/06/21 09:15 PM, Shruti Sridhar wrote: > Hello! > > I have written autopkgtests for seirsplus, salmid and mirtop. > > For mirtop, the tests pass for me in my chroot but seem to fail the > pipeline [4]. Could you please take a look and let me know how I can > proceed?
The error seems to be this: "cannot import name 'version' from 'mirtop' (/tmp/autopkgtest-lxc.bul50sks/downtmp/build.iDg/src/mirtop/__init__.py)" It seems like it is importing from the "local" mirtop source, and not from the installed mirtop package. So the first step is to run the tests not in the project root, but in a temporary dir w/o project root. Next, py3versions -r does not work, so using py3versions -s instead. I think there's a strong preference for using the latter in the python team Next, this was failing with a circular import error as seen here[5]. This error is legit, and it is a candidate for *RC bug* and I believe mirtop should be uploaded with this thing fixed ASAP. I've attempted to (hackishly) fix it here[6], and things look fine both with autopkgtests and on a bit of manual testing. However, I'd appreciate a review before I upload. Mostly, I expect this review from @Andreas. > [1] https://salsa.debian.org/med-team/seirsplus > [2] https://salsa.debian.org/med-team/salmid I think similar changes need to be made here, for testing in a clean temporary dir instead of project root. But at this point, I defer the review for there two to Andreas again. > [3] https://salsa.debian.org/med-team/mirtop > [4] https://salsa.debian.org/med-team/mirtop/-/jobs/1732250#L5487 [5]: https://salsa.debian.org/med-team/mirtop/-/jobs/1732281 [6]: https://salsa.debian.org/med-team/mirtop/-/commit/6a00a05fbb5231916b9705ea81835be41a60e890 Nilesh
signature.asc
Description: PGP signature
