Hi, Thank you so much! I haven't had a chance to work on loompy yet, but I have added tests to Seqsero. Please review and sponsor.
Best, Shruti On Wed, Feb 24, 2021 at 2:33 PM Andreas Tille <andr...@an3as.eu> wrote: > On Wed, Feb 24, 2021 at 02:00:19PM +0530, Nilesh Patra wrote: > > Protecting the master branch is an ideal thing to do since this doesn't > > allow force pushing -- if it wasn't protected, it'd be easy for a new > comer > > who's not very well versed > > with git to mistakenly mess things up. > > ... > > That can have repercussions (see the reply above) -- I'd recommend not > > doing that > > ... > > Probably the rationale is that someone set as "maintainer" can change > > protected branch settings + CI vars et. al -- this can end up causing > > potential damage if accidentally a spammer gets such an access. > > But I suppose we assume good intent most of the times, and it should > > generally be safe. (It's quite OK in Shruti's case, definitely) > > So I think pushing to master branch should be permitted for every > "Developer" and it would be great if we could force this setting > easily on all repositories. > > Kind regards > > Andreas. > > -- > http://fam-tille.de > >
