[ explicitly CCing xnox, as I somehow doubt he follows d-med@ ] [ though I hope the other people mentioned hereafter are subscribed… ]
So, to —putting it bluntly— cut the crap I'm seeing these last days
around libzstd, I'm finalizing the upload.
I'm also deleting the following tags from the git repositories:
* debian/1.3.3+dfsg-2
* debian/1.3.4+dfsg-1
* debian/1.3.4+dfsg-2
Alexandre Mestiashvili, Dimitri John Ledkov, Andreas Tille: please
remove them from your local checkout. I also would like to ask you to
please refrain to push tags for things you are not 100% sure are going
to be accepted (in case you push the tag before receiving the accepted
email, as it seems to be the case here).
Alexandre Mestiashvili: you prepared the last updates (referring to
importing the new upstream releases), but it's clear you never did a
copyright review. Please always check what you imported for updates in
the copyright or the licensing details.
Also looking at some files it seems the generic license of the whole
package is "BSD-3-clause or GPL-2", and I couldn't find any reference in
the whole software of the word "patent" (except in the GPL2 text) -
could you please review this part?
(Incidentally, I also wonder about the legal meaning of things like
Copyright (c) 2016-present
I doubt that means anything really.
Alex Mestiashvili, Sascha Steinbiss, Kevin Murray: there are a bunch of
patches without Forwarded header, that seems like have been there for a
while. Please do some upstreaming work there.
I removed the hurd-i386 patch, according to the upstream bug report the
actual issue has been fixed now (didn't test myself though).
Dimitri Jonhn Ledkov: I reverted your udeb addition. Please do as Cyril
Brulebois says: write a patch, submit it as a bug X-Debbugs-CCing
d-boot@ (and him) for an ACK, once you get it commit and upload.
Then, the actual issue, the symbol files.
Alexandre Mestiashvili: it's not acceptable to just happily remove
symbols. I don't understand what happened as the git log of that file
is noisy, but looking at a simple debdiff the following symbols
disapperead:
- ZSTD_initCCtxParams@Base 1.3.2
- ZSTD_initCCtxParams_advanced@Base 1.3.2
- ZSTD_resetCCtxParams@Base 1.3.2
Where did they went? I can't sensibly upload something that is removing
symbols (i.e. breaking the ABI, but it seems to me that it also break
the API?) without changing SONAME or giving a proper explanation.
I'll be doing some git wrestling and cutting a 1.3.3+dfsg-2 with the
commits that can go in (and then merging in master).
The last point is a blocker for an update to 1.3.4.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
