On 2019-02-21 18:18:06, Holger Levsen wrote: > Hi Antoine, > > On Mon, Feb 18, 2019 at 04:10:47PM -0500, Antoine Beaupré wrote: >> But my little finger tells me there are many DLAs still missing from the >> website. So even if/when the above MR does get merged, more entries will >> be missing. So someone will need to make sure to run the check script to >> make sure no entries are missing regularly, see also: >> https://salsa.debian.org/webmaster-team/cron/merge_requests/1 > > I've looked at this script now, it works nicely, just our results are > not so good yet: > > ~/Projects/debian-www/webwml$ ../cron/parts/10-check-advisories 2>&1 |wc -l > 314 > ~/Projects/debian-www/webwml$ ../cron/parts/10-check-advisories --mode DLA > 2>&1 |wc -l > 1762 > ~/Projects/debian-www/webwml$ ../cron/parts/10-check-advisories --mode DLA > 2>&1 | head -10 > ERROR: .data or .wml file missing for DLA 1685-1 > ERROR: .data or .wml file missing for DLA 1684-1 > ERROR: .data or .wml file missing for DLA 1683-1 > ERROR: .data or .wml file missing for DLA 1660-2 > ERROR: .data or .wml file missing for DLA 1682-1 > ERROR: .data or .wml file missing for DLA 1681-1 > ERROR: .data or .wml file missing for DLA 1680-1 > ERROR: .data or .wml file missing for DLA 1679-1 > ERROR: .data or .wml file missing for DLA 1678-1 > ERROR: .data or .wml file missing for DLA 1677-1 > debian-work:~/Projects/debian-www/webwml$ > > -> this script is incorrect/broken for DLAs it seems, as > https://www.debian.org/lts/security/ does list the DLAs 1677-1681, > just DLAs 1682-1685 are missing. And they are called DLA-1234 there, > not "DLA 1234-1"...
Weird. Is your local checkout up to date? What if you run in debug mode? > Also, if this merge request would be merged, it would just run it in > normal, DSA, mode. Do you have a suggestion how to run it in DLA mode? We could simply change the default here: parser.add_argument('--mode', default='DSA', choices=('DSA', 'DLA'), help='which sort of advisory to check (default: %(default)s)') # noqa: E501 a. -- If you have come here to help me, you are wasting our time. But if you have come because your liberation is bound up with mine, then let us work together. - Aboriginal activists group, Queensland, 1970s