Hi Paul, El 27/11/15 a las 12:35, Paul Gevers escribió: > Hi Santiago, > > On 27-11-15 08:53, Santiago Ruano Rincón wrote: > > Paul, you have suggested the changes to be made on cacti to make it > > compatible with mysql-5.5. Paul or Mahyuddin, would you like to provide > > a package with those changes for squeeze-lts? If that is not the case, I > > could take care of it. > > I would appreciate it when you can do the investigation to come to a > proper solution as you probably have a working setup with both version > installed and I really think this is too much work for me right now. > Once you have defined the solution, I can do the uploading of my own > packages. The problem here: I don't know the details of the change in > MySQL regarding TYPE= vs ENGINE=, but I would expect that packages > probably still need or want to declare the db engine type. >
Well, I have installed cacti from the attached debdiff and available at my personal repo [1]. I have used both mysql-5.1 and mysql-5.5 and it seems to work well. I have also tested upgrading from 5.1 to 5.5, but AFAIU, the error is related to table creation. > If this is true than the solution is going to be rather involved as the > packages probably need some intelligence to detect which version of > MySQL is running (on the server side) before it knows which command to > call. For cacti, this is fully delegated to dbconfig-common (of which I > am now the maintainer and upstream as well). As said, I don't see how to > do this trivially, as you have to detect what version is on the MySQL > server, i.e. not necessarily on the host where you are installing the > package. Now that I think about it, this is probably something that > needs fixing in dbconfig-common anyways and as it was never reported an > issue it probably means that hardly anybody is actually using the > functionality from dbconfig-common to use packages this way (or they fix > it manually and don't bother to report the issue). > > If declaring the engine is really not needed, the fix is trivial and I > will update cacti. If declaring the engine is needed, I ask you to > figure out how dbconfig-common should be patched to allow this detection > as it is not my priority to fix this now. After that I will updated both > dbconfig-common and cacti. > Is there any reason why cacti needs the MyISAM engine? I suppose that if you don't declare it, mysql will use the default engine. Cheers, Santiago [1] deb https://people.debian.org/~santiago/debian santiago-squeeze-lts/ deb-src https://people.debian.org/~santiago/debian santiago-squeeze-lts/
diff -u cacti-0.8.7g/debian/changelog cacti-0.8.7g/debian/changelog --- cacti-0.8.7g/debian/changelog +++ cacti-0.8.7g/debian/changelog @@ -1,3 +1,13 @@ +cacti (0.8.7g-1+squeeze9~1) santiago-squeeze-lts; urgency=high + + * Non-maintainer upload by the Squeeze LTS Team. + * Making cacti compatible against MySQL 5.5: + - cacti.sql: Declare db ENGINE=MyISAM instead of TYPE=MyISAM when creating + tables. Patch from git commit 50acad369b765e77ff4c5fd9f9deb14e909ce21f in + pkg-cacti/cacti. + + -- Santiago Ruano Rincón <santiag...@riseup.net> Sun, 29 Nov 2015 20:59:05 +0100 + cacti (0.8.7g-1+squeeze8) squeeze-lts; urgency=high * Regression update diff -u cacti-0.8.7g/debian/patches/series cacti-0.8.7g/debian/patches/series --- cacti-0.8.7g/debian/patches/series +++ cacti-0.8.7g/debian/patches/series @@ -27,0 +28 @@ +cacti-compatibility-mysql-5.5.patch only in patch2: unchanged: --- cacti-0.8.7g.orig/debian/patches/cacti-compatibility-mysql-5.5.patch +++ cacti-0.8.7g/debian/patches/cacti-compatibility-mysql-5.5.patch @@ -0,0 +1,488 @@ +commit 50acad369b765e77ff4c5fd9f9deb14e909ce21f +Author: Mahyuddin Susanto <udi...@ubuntu.com> +Date: Thu Oct 13 15:24:43 2011 +0700 + + Refreshing pathes + +diff --git a/cacti.sql b/cacti.sql +index bd8dfa6..d186bce 100644 +--- a/cacti.sql ++++ b/cacti.sql +@@ -7,7 +7,7 @@ CREATE TABLE cdef ( + hash varchar(32) NOT NULL default '', + name varchar(255) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `cdef` +@@ -33,7 +33,7 @@ CREATE TABLE cdef_items ( + value varchar(150) NOT NULL default '', + PRIMARY KEY (id), + KEY cdef_id (cdef_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `cdef_items` +@@ -64,7 +64,7 @@ CREATE TABLE colors ( + id mediumint(8) unsigned NOT NULL auto_increment, + hex varchar(6) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `colors` +@@ -184,7 +184,7 @@ CREATE TABLE data_input ( + type_id tinyint(2) NOT NULL default '0', + PRIMARY KEY (id), + KEY name (name) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_input` +@@ -214,7 +214,7 @@ CREATE TABLE data_input_data ( + value text, + PRIMARY KEY (data_input_field_id,data_template_data_id), + KEY t_value (t_value) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_input_data` +@@ -418,7 +418,7 @@ CREATE TABLE data_input_fields ( + PRIMARY KEY (id), + KEY data_input_id (data_input_id), + KEY type_code (type_code) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_input_fields` +@@ -482,7 +482,7 @@ CREATE TABLE data_local ( + snmp_query_id mediumint(8) NOT NULL default '0', + snmp_index varchar(255) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_local` +@@ -503,7 +503,7 @@ CREATE TABLE data_template ( + hash varchar(32) NOT NULL default '', + name varchar(150) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_template` +@@ -573,7 +573,7 @@ CREATE TABLE data_template_data ( + PRIMARY KEY (id), + KEY local_data_id (local_data_id), + KEY data_template_id (data_template_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_template_data` +@@ -635,7 +635,7 @@ CREATE TABLE data_template_data_rra ( + rra_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (data_template_data_id,rra_id), + KEY data_template_data_id (data_template_data_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_template_data_rra` +@@ -849,10 +849,11 @@ CREATE TABLE data_template_rrd ( + t_data_input_field_id char(2) default NULL, + data_input_field_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (id), ++ UNIQUE KEY `duplicate_dsname_contraint` (`local_data_id`,`data_source_name`,`data_template_id`), + KEY local_data_id (local_data_id), + KEY data_template_id (data_template_id), + KEY local_data_template_rrd_id (local_data_template_rrd_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `data_template_rrd` +@@ -936,7 +937,7 @@ CREATE TABLE graph_local ( + KEY graph_template_id (graph_template_id), + KEY snmp_query_id (snmp_query_id), + KEY snmp_index (snmp_index) +-) TYPE=MyISAM COMMENT='Creates a relationship for each item in a custom graph.'; ++) ENGINE=MyISAM COMMENT='Creates a relationship for each item in a custom graph.'; + + -- + -- Dumping data for table `graph_local` +@@ -959,7 +960,7 @@ CREATE TABLE graph_template_input ( + description text, + column_name varchar(50) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM COMMENT='Stores the names for graph item input groups.'; ++) ENGINE=MyISAM COMMENT='Stores the names for graph item input groups.'; + + -- + -- Dumping data for table `graph_template_input` +@@ -1052,7 +1053,7 @@ CREATE TABLE graph_template_input_defs ( + graph_template_item_id int(12) unsigned NOT NULL default '0', + PRIMARY KEY (graph_template_input_id,graph_template_item_id), + KEY graph_template_input_id (graph_template_input_id) +-) TYPE=MyISAM COMMENT='Stores the relationship for what graph iitems are associated'; ++) ENGINE=MyISAM COMMENT='Stores the relationship for what graph iitems are associated'; + + -- + -- Dumping data for table `graph_template_input_defs` +@@ -1326,7 +1327,7 @@ CREATE TABLE graph_templates ( + name char(255) NOT NULL default '', + PRIMARY KEY (id), + KEY name (name) +-) TYPE=MyISAM COMMENT='Contains each graph template name.'; ++) ENGINE=MyISAM COMMENT='Contains each graph template name.'; + + -- + -- Dumping data for table `graph_templates` +@@ -1376,7 +1377,7 @@ CREATE TABLE graph_templates_gprint ( + name varchar(100) NOT NULL default '', + gprint_text varchar(255) default NULL, + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `graph_templates_gprint` +@@ -1438,7 +1439,7 @@ CREATE TABLE graph_templates_graph ( + KEY local_graph_id (local_graph_id), + KEY graph_template_id (graph_template_id), + KEY title_cache (title_cache) +-) TYPE=MyISAM COMMENT='Stores the actual graph data.'; ++) ENGINE=MyISAM COMMENT='Stores the actual graph data.'; + + -- + -- Dumping data for table `graph_templates_graph` +@@ -1507,7 +1508,7 @@ CREATE TABLE graph_templates_item ( + KEY graph_template_id (graph_template_id), + KEY local_graph_id (local_graph_id), + KEY task_item_id (task_item_id) +-) TYPE=MyISAM COMMENT='Stores the actual graph item data.'; ++) ENGINE=MyISAM COMMENT='Stores the actual graph item data.'; + + -- + -- Dumping data for table `graph_templates_item` +@@ -1803,7 +1804,7 @@ CREATE TABLE graph_tree ( + sort_type tinyint(3) unsigned NOT NULL default '1', + name varchar(255) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `graph_tree` +@@ -1830,7 +1831,7 @@ CREATE TABLE graph_tree_items ( + KEY host_id (host_id), + KEY local_graph_id (local_graph_id), + KEY order_key (order_key) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `graph_tree_items` +@@ -1864,6 +1865,7 @@ CREATE TABLE host ( + ping_timeout int(12) unsigned default '500', + ping_retries int(12) unsigned default '2', + max_oids int(12) unsigned default '10', ++ device_threads tinyint(2) unsigned NOT NULL DEFAULT '1', + disabled char(2) default NULL, + status tinyint(2) NOT NULL default '0', + status_event_count mediumint(8) unsigned NOT NULL default '0', +@@ -1879,13 +1881,13 @@ CREATE TABLE host ( + availability decimal(8,5) NOT NULL default '100.00000', + PRIMARY KEY (id), + KEY disabled (disabled) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host` + -- + +-INSERT INTO `host` VALUES (1, 8, 'Localhost', '127.0.0.1', '', 'public', 0, '', '', 'MD5', '', 'DES', '', 161, 500, 3, 2, 23, 400, 1, 10, '', 0, 0, '0000-00-00 00:00:00', '0000-00-00 00:00:00', '', 9.99999, 0.00000, 0.00000, 0.00000, 0, 0, 100.00000); ++INSERT INTO `host` VALUES (1, 8, 'Localhost', '127.0.0.1', '', 'public', 0, '', '', 'MD5', '', 'DES', '', 161, 500, 3, 2, 23, 400, 1, 10, 1, '', 0, 0, '0000-00-00 00:00:00', '0000-00-00 00:00:00', '', 9.99999, 0.00000, 0.00000, 0.00000, 0, 0, 100.00000); + + -- + -- Table structure for table `host_graph` +@@ -1895,7 +1897,7 @@ CREATE TABLE host_graph ( + host_id mediumint(8) unsigned NOT NULL default '0', + graph_template_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (host_id,graph_template_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_graph` +@@ -1917,13 +1919,15 @@ CREATE TABLE host_snmp_cache ( + field_value varchar(255) default NULL, + snmp_index varchar(255) NOT NULL default '', + oid TEXT NOT NULL, ++ present tinyint NOT NULL DEFAULT '1', + PRIMARY KEY (host_id,snmp_query_id,field_name,snmp_index), + KEY host_id (host_id,field_name), + KEY snmp_index (snmp_index), + KEY field_name (field_name), + KEY field_value (field_value), +- KEY snmp_query_id (snmp_query_id) +-) TYPE=MyISAM; ++ KEY snmp_query_id (snmp_query_id), ++ KEY present (present) ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_snmp_cache` +@@ -1942,7 +1946,7 @@ CREATE TABLE host_snmp_query ( + reindex_method tinyint(3) unsigned NOT NULL default '0', + PRIMARY KEY (host_id,snmp_query_id), + KEY host_id (host_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_snmp_query` +@@ -1959,7 +1963,7 @@ CREATE TABLE host_template ( + hash varchar(32) NOT NULL default '', + name varchar(100) NOT NULL default '', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_template` +@@ -1982,7 +1986,7 @@ CREATE TABLE host_template_graph ( + graph_template_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (host_template_id,graph_template_id), + KEY host_template_id (host_template_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_template_graph` +@@ -2012,7 +2016,7 @@ CREATE TABLE host_template_snmp_query ( + snmp_query_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (host_template_id,snmp_query_id), + KEY host_template_id (host_template_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `host_template_snmp_query` +@@ -2042,7 +2046,7 @@ CREATE TABLE poller ( + ip_address int(11) unsigned NOT NULL default '0', + last_update datetime NOT NULL default '0000-00-00 00:00:00', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller` +@@ -2059,7 +2063,7 @@ CREATE TABLE poller_command ( + action tinyint(3) unsigned NOT NULL default '0', + command varchar(200) NOT NULL default '', + PRIMARY KEY (poller_id,action,command) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller_command` +@@ -2075,6 +2079,7 @@ CREATE TABLE poller_item ( + poller_id smallint(5) unsigned NOT NULL default '0', + host_id mediumint(8) NOT NULL default '0', + action tinyint(2) unsigned NOT NULL default '1', ++ present tinyint NOT NULL DEFAULT '1', + hostname varchar(250) NOT NULL default '', + snmp_community varchar(100) NOT NULL default '', + snmp_version tinyint(1) unsigned NOT NULL default '0', +@@ -2098,8 +2103,9 @@ CREATE TABLE poller_item ( + KEY local_data_id (local_data_id), + KEY host_id (host_id), + KEY rrd_next_step (rrd_next_step), +- KEY action (action) +-) TYPE=MyISAM; ++ KEY action (action), ++ KEY present (present) ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller_item` +@@ -2116,7 +2122,7 @@ CREATE TABLE poller_output ( + time datetime NOT NULL default '0000-00-00 00:00:00', + output text NOT NULL, + PRIMARY KEY (local_data_id,rrd_name,time) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller_output` +@@ -2131,11 +2137,13 @@ CREATE TABLE poller_reindex ( + host_id mediumint(8) unsigned NOT NULL default '0', + data_query_id mediumint(8) unsigned NOT NULL default '0', + action tinyint(3) unsigned NOT NULL default '0', ++ present tinyint NOT NULL DEFAULT '1', + op char(1) NOT NULL default '', + assert_value varchar(100) NOT NULL default '', + arg1 varchar(255) NOT NULL default '', +- PRIMARY KEY (host_id,data_query_id,arg1) +-) TYPE=MyISAM; ++ PRIMARY KEY (host_id,data_query_id,arg1), ++ KEY present (present) ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller_reindex` +@@ -2153,7 +2161,7 @@ CREATE TABLE poller_time ( + start_time datetime NOT NULL default '0000-00-00 00:00:00', + end_time datetime NOT NULL default '0000-00-00 00:00:00', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `poller_time` +@@ -2173,7 +2181,7 @@ CREATE TABLE rra ( + rows int(12) NOT NULL default '600', + timespan int(12) unsigned NOT NULL default '0', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `rra` +@@ -2194,7 +2202,7 @@ CREATE TABLE rra_cf ( + consolidation_function_id smallint(5) unsigned NOT NULL default '0', + PRIMARY KEY (rra_id,consolidation_function_id), + KEY rra_id (rra_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `rra_cf` +@@ -2219,7 +2227,7 @@ CREATE TABLE settings ( + name varchar(50) NOT NULL default '', + value varchar(255) NOT NULL default '', + PRIMARY KEY (name) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `settings` +@@ -2235,7 +2243,7 @@ CREATE TABLE settings_graphs ( + name varchar(50) NOT NULL default '', + value varchar(255) NOT NULL default '', + PRIMARY KEY (user_id,name) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `settings_graphs` +@@ -2251,7 +2259,7 @@ CREATE TABLE settings_tree ( + graph_tree_item_id mediumint(8) unsigned NOT NULL default '0', + status tinyint(1) NOT NULL default '0', + PRIMARY KEY (user_id,graph_tree_item_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `settings_tree` +@@ -2272,7 +2280,7 @@ CREATE TABLE snmp_query ( + data_input_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (id), + KEY name (name) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `snmp_query` +@@ -2298,7 +2306,7 @@ CREATE TABLE snmp_query_graph ( + name varchar(100) NOT NULL default '', + graph_template_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `snmp_query_graph` +@@ -2336,7 +2344,7 @@ CREATE TABLE snmp_query_graph_rrd ( + PRIMARY KEY (snmp_query_graph_id,data_template_id,data_template_rrd_id), + KEY data_template_rrd_id (data_template_rrd_id), + KEY snmp_query_graph_id (snmp_query_graph_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `snmp_query_graph_rrd` +@@ -2397,7 +2405,7 @@ CREATE TABLE snmp_query_graph_rrd_sv ( + PRIMARY KEY (id), + KEY snmp_query_graph_id (snmp_query_graph_id), + KEY data_template_id (data_template_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `snmp_query_graph_rrd_sv` +@@ -2476,7 +2484,7 @@ CREATE TABLE snmp_query_graph_sv ( + text varchar(255) NOT NULL default '', + PRIMARY KEY (id), + KEY snmp_query_graph_id (snmp_query_graph_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `snmp_query_graph_sv` +@@ -2548,7 +2556,7 @@ CREATE TABLE user_auth ( + KEY username (username), + KEY realm (realm), + KEY enabled (enabled) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `user_auth` +@@ -2567,7 +2575,7 @@ CREATE TABLE user_auth_perms ( + type tinyint(2) unsigned NOT NULL default '0', + PRIMARY KEY (user_id,item_id,type), + KEY user_id (user_id,type) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `user_auth_perms` +@@ -2583,7 +2591,7 @@ CREATE TABLE user_auth_realm ( + user_id mediumint(8) unsigned NOT NULL default '0', + PRIMARY KEY (realm_id,user_id), + KEY user_id (user_id) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `user_auth_realm` +@@ -2619,7 +2627,7 @@ CREATE TABLE user_log ( + ip varchar(40) NOT NULL default '', + PRIMARY KEY (username,user_id,time), + KEY username (username) +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `user_log` +@@ -2632,7 +2640,7 @@ CREATE TABLE user_log ( + + CREATE TABLE version ( + cacti char(20) default NULL +-) TYPE=MyISAM; ++) ENGINE=MyISAM; + + -- + -- Dumping data for table `version`
signature.asc
Description: Digital signature
