El 09/03/19 a las 15:03, Thomas Schmitt escribió: > Hi, > > adrian15 wrote: >> Well, guess what happened... my obvious patch: >> if ! search --set=root --file /live/vmlinuz ; then > search --set=root --file /live/vmlinuz1 >> does not boot in my computer because it's still finding /live/vmlinuz in >> the internal hard disk. > > That's the second bad spinoff from using as ISO earmark a file which > already has a different job. > (First in my counting is that a change in kernel naming inadvertedly > could spoil the recognition of the ISO.) > > >> 3) I'll try to code this dedicated unique identification file path that >> you are proposing and see if it works better. > > I am pondering whether the name should be long and human readable > like "d-live_9.4.0_xf_amd64" or short and bootloader agnostic like > "0F63AE66.87F" (*). > The former needs Rock Ridge support to be recognizable (GRUB2 has it, > afaic), the latter would show up the same in all naming systems of > the ISO. Be it plain ISO 9660 level 1, Rock Ridge, or Joliet. > > (*) The short name was derived by: > > x=$(echo -n 'd-live 9.4.0 xf amd64' | md5sum | tr 'a-z' 'A-Z' | dd bs=1 > count=11) > name=$(echo "$x" | dd bs=1 count=8)"."$(echo "$x" | dd bs=1 skip=8 count=3) > > (I am sure it can be done more elegantly.) > > > Have a nice day :) > > Thomas
I am currently building and testing a label search approach. It works manually on both UEFI USB boot and TianaCore UEFI CDROM boot. The patch is here: https://github.com/rescatux/live-build/commit/2716635f6314bba1d94f0693a33bbb55eba323e5 and, well it's quite simple: replace: search --set=root --file /live/vmlinuz with: search --set=root --label \"${LB_ISO_VOLUME}\" . I might discard this label approach and take yours because of tools to remaster distros. If I hard code 'DebianLive87' or whatever Debian label is then anyone who wants modify minimally the iso then needs to reconstruct the efi.img file so that it searchs for their label. Because, obviously when you remaster an ISO you want to put your volume name and not "Debian", "Ubuntu" or whatever. Your filename base approach just enforces the remaster tool to find an unknown 8.3 file and make sure to copy it. Or maybe every single file at device root ? It's way simpler than mine. So Thomas... any more thoughts that you can bring me in... to make remaster tools work easier? Maybe I'm missing something obvious. Thank you. adrian15 -- Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
