Hello guys, I tried to merged all pending patches recently and I just came on this discussion and this bug submission.
On Fri, 16 Jun 2017, William Prochazka wrote: > I concede that I didn't realize the module file could include a raw > directory since the man page refers to disk images. Maybe you can send a patch to update the documentation too? On Tue, 20 Jun 2017, Mert Dirik wrote: > I should note that I'm just an outsider of this project so I don't have a > say in what can or can not be accepted. I only replied because added > functionality seemed redundant and I wanted to point it out. Now that I got > my message across I count myself successfull :). I'm aware there is also > some other functionality in your patch but I didn't really checked them and > you should decide whether to clean them up to leverage existing > functionality and push it for inclusion. Thank you for your comments anyway. It helped to put things into perspective. William, I would like you to send me an update on all this and to resubmit the patches which are still relevant as merge request on https://salsa.debian.org/live-team/live-boot Please don't mix multiple features in a single commit. It's easier to review when clearly separated. And if they don't depend on each other, then submit them as different merge requests, it's even better. Please include updated documentation in your patch. This was clearly missing from what I saw quickly. Note that I pushed multiple changes recently (and notably the switch to /run/live instead of /lib/live/mount) which will impact your patch. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
