Hi, Baurzhan Muftakhidinov wrote (21 Nov 2011 10:50:19 GMT) : > Added simple check for udev version, but not exactly the best coding > style ;)
Checking if /lib/udev/path_id exists would be quite more robust than a version check, don't you think? Other than this, PATH_ID should be spelled in lowercase (consistency with all other "local" variables in functions), and probably called path_id_command for clarity's sake. (Yeah, it would not take that much time to fix it myself, but I'm happy helping you going the whole way to a patch that we can apply as is. This way, you'll know better what we expect next time.) Cheers, -- intrigeri <intrig...@boum.org> | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc | Then we'll come from the shadows. -- To UNSUBSCRIBE, email to debian-live-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/85sjlh67xh....@boum.org
