Hi Nilesh, Nilesh Patra wrote: > On Mon, May 06, 2024 at 03:58:54AM +0200, Axel Beckert wrote: > > The release won't happen tonight anymore, though. Need to go to bed > > now. Also Salsa consistently spews "Something went wrong. Please try > > again." when trying to rebase some more merge requests. Pipelines for > > 6 more now rebased merge requests are currently running (or pending) > > on Salsa. Will check the results tomorrow—eh—later today. > > There were 3 merge request which you marked as "Approve" but not merge > possibly > due to salsa pitfalls?
Mostly, yes. > I took the liberty to merge the three (!471, !472 and !499). Please revert > (and > comment) if you think it was a mistake. Well, !499 has a (actually still pending) open question for review: https://salsa.debian.org/lintian/lintian/-/merge_requests/499#note_483348 Didn't expect a merge before that question is solved. Would be happy if you could still have a look at my questions and if necessary push according changes (maybe with "Git-Dch: Ignore"). But we also haven't really rules what approval, thumbs up, etc. exactly mean. So maybe that was the problem. :-) For me approval is a general ok for the concept and an intend to merge, but not necessarily in the current state. But maybe thumbs up is better for that purpose? Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
signature.asc
Description: PGP signature
