[PATCH]Re: [2.4]ALi M5451 sound hangs on init; workaround

[Fedor Karpelevitch]

On Среда 11 Декабрь 2002 13:12, Alan Cox wrote:
> On Wed, 2002-12-11 at 19:42, Fedor Karpelevitch wrote:
> > So I wonder what toggling those bits is supposed to change. I
> > would test that somehow then
>
> 6 channel audio mode

so here is the patch against 2.4.21-pre1 (I beleive it should equally 
apply to 20-ac2)
It works for me and fixes all four occurences of that error in the 
driver.

Fedor



--- linux-2.4.21-pre1-tridfix/drivers/sound/trident.c.orig      2002-12-12 
15:28:00.000000000 -0800
+++ linux-2.4.21-pre1-tridfix/drivers/sound/trident.c   2002-12-12 15:30:48.000000000 
+-0800
@@ -3368,15 +3368,17 @@
         pci_dev = pci_find_device(PCI_VENDOR_ID_AL,PCI_DEVICE_ID_AL_M1533, pci_dev);
         if (pci_dev == NULL)
                 return -1;
-       temp = 0x80;
-       pci_write_config_byte(pci_dev, 0x59, ~temp);
+       pci_read_config_byte(pci_dev, 0x59, &temp);
+       temp &= ~0x80;
+       pci_write_config_byte(pci_dev, 0x59, temp);
        
        pci_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M7101, pci_dev);
        if (pci_dev == NULL)
                 return -1;
 
-       temp = 0x20;
-       pci_write_config_byte(pci_dev, 0xB8, ~temp);
+       pci_read_config_byte(pci_dev, 0xB8, &temp);
+       temp &= ~0x20;
+       pci_write_config_byte(pci_dev, 0xB8, temp);
 
        return 0;
 }
@@ -3390,13 +3392,15 @@
        pci_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, pci_dev);
        if (pci_dev == NULL)
                 return -1;
-       temp = 0x80;
+       pci_read_config_byte(pci_dev, 0x59, &temp);
+       temp |= 0x80;
        pci_write_config_byte(pci_dev, 0x59, temp);
        
        pci_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M7101, pci_dev);
        if (pci_dev == NULL)
                 return -1;
-       temp = 0x20;
+       pci_read_config_byte(pci_dev, (int)0xB8, &temp);
+       temp |= 0x20;
        pci_write_config_byte(pci_dev, (int)0xB8,(u8) temp);
        if (chan_nums == 6) {
                dwValue = inl(TRID_REG(card, ALI_SCTRL)) | 0x000f0000;