On Tue, Jul 23, 2013 at 10:09:38PM +0100, Roger Leigh wrote:
> On 23/07/13 18:48, Michael Prokop wrote:
> >[Cc-ing everyone who was involved in discussing #652459]
>
> (Also copying Adam Conrad and Steve Langasek.)
>
> >* Roger Leigh [Sun May 12, 2013 at 06:53:11PM +0100]:
> >
> >>And one final patch to use panic rather than sulogin on fsck failure.
> >
> >Thanks for all your patches, I've applied them on top of current
> >master (and edited debian/changelog on my own, being based on your
> >patches). The result is currently sitting in branch mika/bug_652459
> >of initramfs-tools.git.
> >
> >Does anyone have any objections against the current implementation
> >of #652459 to support mounting of /usr in the initramfs?
> >If so, which objections do you have and what needs to be done to
> >resolve this issue so all involved parties are happy?
The shell parsing of /etc/fstab would run on any boot?
nitpicking read_fstab_entry():
- useless loop, please just assign:
+ for file in ${rootmnt}/etc/fstab; do
+ if [ -f "$file" ]; then
Please reverse logic and immediately return if no fstab
+ if [ "$MNT_DIR" = "$1" ]; then
similary please just unwrap that too.
thanks.
--
maks
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130723233045.ga4...@stro.at
