On Mon, Oct 29, 2012 at 11:49:37PM -0700, Jonathan Nieder wrote:
> Uwe Kleine-König wrote:
>
> > I guess they do, but their existence isn't obvious for the random Debian
> > user who is willing to test a patch for us.
>
> For reference: the implied documentation bug is now filed at
> http://bugs.debian.org/691816
>
> > Something like this would be nice:
> >
> > $ debian/bin/test-patches
> > Usage: debian/bin/test-patches [<options>] <patch>...
> > Options:
> > -c use ccache for compilation
> > -d don't build debug packages
> > -f <flavour> specify the 'flavour' of kernel to build, e.g. 686-pae
> > -j <jobs> specify number of compiler jobs to run in parallel
> > -s <featureset> specify an optional featureset to apply, e.g. rt
> >
> > For DEBIAN_KERNEL_DISABLE_DEBUG it might even be worth to default to no
> > debug packages and use -d to enable them?!
>
> Sounds sane. How about something like this?
Looks good, only some nitpicking below ...
> Index: debian/bin/test-patches
> ===================================================================
> --- debian/bin/test-patches (révision 19472)
> +++ debian/bin/test-patches (copie de travail)
> @@ -19,9 +19,15 @@
> featureset=none
> fi
>
> -eval "set -- $(getopt -n "$0" -- "f:j:s:" "$@")"
> +if [ -z "${DEBIAN_KERNEL_DISABLE_DEBUG+set}" ]; then
I don't know that construct, only :+, but + seems to do the same without
me finding it in the manpage of neither bash nor dash.
> + export DEBIAN_KERNEL_DISABLE_DEBUG='yes, from debian/bin/test-patches'
I'd have written:
'yes, default from debian/bin/test-patches'
> +fi
> +
> +eval "set -- $(getopt -n "$0" -- "cdf:j:s:" "$@")"
> while true; do
> case "$1" in
> + -c) export DEBIAN_KERNEL_USE_CCACHE='yes, from commandline'; shift 1 ;;
"yes, from debian/bin/test-patches' commandline"
Not sure these strings appear somewhere where the actual content is
helpful.
Other than that I like your change.
Best regards
Uwe
> + -d) export DEBIAN_KERNEL_DISABLE_DEBUG=; shift 1 ;;
> -f) flavour="$2"; shift 2 ;;
> -j) export MAKEFLAGS="$MAKEFLAGS -j$2"; shift 2 ;;
> -s) featureset="$2"; shift 2 ;;
> @@ -33,6 +39,8 @@
> echo >&2 "Usage: $0 [<options>] <patch>..."
> cat >&2 <<EOF
> Options:
> + -c use ccache for compilation
> + -d build debug packages, too
> -f <flavour> specify the 'flavour' of kernel to build, e.g. 686-pae
> -j <jobs> specify number of compiler jobs to run in parallel
> -s <featureset> specify an optional featureset to apply, e.g. rt
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121030094629.gw...@pengutronix.de
