On Wed, 7 Dec 2011, Russell King - ARM Linux wrote: > On Wed, Dec 07, 2011 at 11:05:58PM +0100, Arnaud Patard wrote: > > I may be wrong but it seems that arm_dma_zone_size is used before being > > set. It would be interesting if someone can boot test a nslu2 kernel with > > appended patch. > > It does look like that's the case - arm_dma_zone_size is used in > arm_bootmem_free(), which is called from bootmem_init() and in turn > paging_init(). > > So, arm_dma_zone_size needs to be set before paging_init() is called.
Oops, indeed. > I'd actually suggest moving it before: > > if (mdesc->restart_mode) > reboot_setup(&mdesc->restart_mode); > > so that it's set real early, to avoid any future problems with this. > The earlier these kinds of things are set, the less likely this kind > of bug will happen. Arnaud: please resubmit your patch moving the call as suggested by Russell and mark it with: Acked-by: Nicolas Pitre <n...@linaro.org> and CC: sta...@kernel.org Thanks Nicolas -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.lfd.2.02.1112071902360.2...@xanadu.home
