On Tue, 2011-08-30 at 10:22 -0400, Konrad Rzeszutek Wilk wrote:
> It might make sense to also use 'xen_raw_printk' as sometimes you don't
> get to see the panic - you end up with this unhelpfull message:
>
> (XEN) domain_crash_sync called from entry.S
> (XEN) Domain 0 (vcpu#0) crashed on cpu#0:
> .. snip..
>
> so something like this:
Fine by me, although I do wonder if maybe we shouldn't be fixing panic()
itself or our console driver or something, this isn't the first such
patch I've noticed which doubles up on the panic message. Is the
underlying issue just that earlyprintk isn't on by default?
> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
> index b4533a8..8424dd4 100644
> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
> @@ -32,6 +32,7 @@
> #include <xen/page.h>
> #include <xen/events.h>
>
> +#include <xen/hvc-console.h>
> #include "xen-ops.h"
> #include "mmu.h"
>
> @@ -207,6 +208,15 @@ static void __init xen_smp_prepare_cpus(unsigned int
> max_cpus)
> unsigned cpu;
> unsigned int i;
>
> + if (skip_ioapic_setup) {
> + char *m = (max_cpus == 0) ?
> + "The nosmp parameter is incompatible with Xen; " \
> + "use Xen dom0_max_vcpus=1 parameter" :
> + "The noapic parameter is incompatible with Xen";
> +
> + xen_raw_printk(m);
> + panic(m);
> + }
> xen_init_lock_cpu(0);
>
> smp_store_cpu_info(0);
>
>
>
--
Ian Campbell
Current Noise: Nebula - All The Way
I do not know myself and God forbid that I should.
-- Johann Wolfgang von Goethe
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/1314777700.28989.25.ca...@zakaz.uk.xensource.com
