Herbert, Does the warning below look like a symptom of the bug you fixed with this commit?
commit 622e0ca1cd4d459f5af4f2c65f4dc0dd823cb4c3 Author: Herbert Xu <herb...@gondor.apana.org.au> Date: Thu May 20 23:07:56 2010 -0700 gro: Fix bogus gso_size on the first fraglist entry Ben. On Tue, 2010-09-14 at 13:01 +0400, Boris Savelev wrote: [...] > At one night I received 2 GB size kern.log with repeated messages: > > Sep 14 11:25:18 buildbot2 kernel: [85054.424096] ------------[ cut here > ]------------ > Sep 14 11:25:18 buildbot2 kernel: [85054.424157] WARNING: at /build/buildd- > linux-2.6_2.6.32-21-amd64-bEMv9E/linux-2.6-2.6.32/debian/build/so > urce_amd64_xen/net/core/dev.c:1582 skb_gso_segment+0x109/0x263() > Sep 14 11:25:18 buildbot2 kernel: [85054.424298] Hardware name: S5500WB > Sep 14 11:25:18 buildbot2 kernel: [85054.424344] tun: caps=(0x0, 0x0) len=1500 > data_len=0 ip_summed=0 > Sep 14 11:25:18 buildbot2 kernel: [85054.424368] Modules linked in: xt_physdev > tun nfs lockd fscache nfs_acl auth_rpcgss sunrpc ipt_MASQUERA > DE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack > ipt_REJECT xt_tcpudp bridge stp ip6table_filter ip6_tables ipta > ble_filter ip_tables x_tables xen_evtchn xenfs fuse ext2 loop snd_pcm > snd_timer > snd soundcore snd_page_alloc i2c_i801 i2c_core joydev evdev > pcspkr ioatdma button processor acpi_processor ext3 jbd mbcache dm_mod sg > usbhid hid sr_mod cdrom sd_mod crc_t10dif ata_generic uhci_hcd ata > _piix libata ehci_hcd usbcore nls_base aacraid scsi_mod thermal igb > thermal_sys > dca [last unloaded: scsi_wait_scan] > Sep 14 11:25:18 buildbot2 kernel: [85054.425199] Pid: 0, comm: swapper > Tainted: > G W 2.6.32-5-xen-amd64 #1 > Sep 14 11:25:18 buildbot2 kernel: [85054.425257] Call Trace: > Sep 14 11:25:18 buildbot2 kernel: [85054.425300] <IRQ> [<ffffffff8125e3e1>] > ? > skb_gso_segment+0x109/0x263 > Sep 14 11:25:18 buildbot2 kernel: [85054.425364] [<ffffffff8125e3e1>] ? > skb_gso_segment+0x109/0x263 > Sep 14 11:25:18 buildbot2 kernel: [85054.425422] [<ffffffff8104ea3c>] ? > warn_slowpath_common+0x77/0xa3 > Sep 14 11:25:18 buildbot2 kernel: [85054.425480] [<ffffffff8104eac4>] ? > warn_slowpath_fmt+0x51/0x59 > Sep 14 11:25:18 buildbot2 kernel: [85054.425537] [<ffffffff812565bc>] ? > pskb_expand_head+0xe9/0x16d > Sep 14 11:25:18 buildbot2 kernel: [85054.425593] [<ffffffff812573a1>] ? > skb_segment+0x267/0x4d4 > Sep 14 11:25:18 buildbot2 kernel: [85054.425650] [<ffffffff812689fc>] ? > inet_proto_csum_replace4+0x38/0xb2 > Sep 14 11:25:18 buildbot2 kernel: [85054.425710] [<ffffffffa02a4579>] ? > tun_get_drvinfo+0x3c/0x76 [tun] > Sep 14 11:25:18 buildbot2 kernel: [85054.425767] [<ffffffff8125e3e1>] ? > skb_gso_segment+0x109/0x263 > Sep 14 11:25:18 buildbot2 kernel: [85054.425823] [<ffffffff8125e6eb>] ? > dev_hard_start_xmit+0x1b0/0x2b8 > Sep 14 11:25:18 buildbot2 kernel: [85054.425882] [<ffffffff81271a70>] ? > sch_direct_xmit+0x58/0x14c > Sep 14 11:25:18 buildbot2 kernel: [85054.425938] [<ffffffff8125eb46>] ? > dev_queue_xmit+0x252/0x38d > Sep 14 11:25:18 buildbot2 kernel: [85054.425997] [<ffffffffa01dcc51>] ? > br_dev_queue_push_xmit+0x75/0x79 [bridge] > Sep 14 11:25:18 buildbot2 kernel: [85054.426058] [<ffffffffa01dc2c1>] ? > br_dev_xmit+0x66/0x7d [bridge] > Sep 14 11:25:18 buildbot2 kernel: [85054.426115] [<ffffffff8125e78e>] ? > dev_hard_start_xmit+0x253/0x2b8 > Sep 14 11:25:18 buildbot2 kernel: [85054.426172] [<ffffffff8125ebd1>] ? > dev_queue_xmit+0x2dd/0x38d > Sep 14 11:25:18 buildbot2 kernel: [85054.426229] [<ffffffff81281903>] ? > ip_rcv_finish+0x373/0x38d > Sep 14 11:25:18 buildbot2 kernel: [85054.426283] [<ffffffff81281bbd>] ? > ip_rcv+0x2a0/0x2ed > Sep 14 11:25:18 buildbot2 kernel: [85054.426337] [<ffffffff8125ddf5>] ? > dev_gro_receive+0xfd/0x224 > Sep 14 11:25:18 buildbot2 kernel: [85054.426394] [<ffffffff8119c633>] ? > is_xen_swiotlb_buffer+0x4a/0x9d > Sep 14 11:25:18 buildbot2 kernel: [85054.426451] [<ffffffff8125e03f>] ? > napi_gro_receive+0x20/0x2e > Sep 14 11:25:18 buildbot2 kernel: [85054.426511] [<ffffffffa0010693>] ? > igb_poll+0x4e8/0x82f [igb] > Sep 14 11:25:18 buildbot2 kernel: [85054.426569] [<ffffffff810fcff4>] ? > pollwake+0x53/0x5b > Sep 14 11:25:18 buildbot2 kernel: [85054.426622] [<ffffffff8125e16f>] ? > net_rx_action+0xae/0x1c9 > Sep 14 11:25:18 buildbot2 kernel: [85054.426679] [<ffffffff810547cb>] ? > __do_softirq+0xdd/0x1a2 > Sep 14 11:25:18 buildbot2 kernel: [85054.426736] [<ffffffff81012cac>] ? > call_softirq+0x1c/0x30 > Sep 14 11:25:18 buildbot2 kernel: [85054.426791] [<ffffffff8101422b>] ? > do_softirq+0x3f/0x7c > Sep 14 11:25:18 buildbot2 kernel: [85054.426846] [<ffffffff8105463a>] ? > irq_exit+0x36/0x76 > Sep 14 11:25:18 buildbot2 kernel: [85054.426900] [<ffffffff811f1155>] ? > xen_evtchn_do_upcall+0x33/0x42 > Sep 14 11:25:18 buildbot2 kernel: [85054.426958] [<ffffffff81012cfe>] ? > xen_do_hypervisor_callback+0x1e/0x30 > Sep 14 11:25:18 buildbot2 kernel: [85054.427014] <EOI> [<ffffffff810093aa>] > ? > hypercall_page+0x3aa/0x1001 > Sep 14 11:25:18 buildbot2 kernel: [85054.427078] [<ffffffff810093aa>] ? > hypercall_page+0x3aa/0x1001 > Sep 14 11:25:18 buildbot2 kernel: [85054.427135] [<ffffffff8100eb8d>] ? > xen_vcpuop_set_next_event+0x0/0x60 > Sep 14 11:25:18 buildbot2 kernel: [85054.427194] [<ffffffff8100e633>] ? > xen_safe_halt+0xc/0x15 > Sep 14 11:25:18 buildbot2 kernel: [85054.427248] [<ffffffff8100bf3f>] ? > xen_idle+0x37/0x40 > Sep 14 11:25:18 buildbot2 kernel: [85054.427301] [<ffffffff81010eb1>] ? > cpu_idle+0xa2/0xda > Sep 14 11:25:18 buildbot2 kernel: [85054.427356] [<ffffffff81506cd1>] ? > start_kernel+0x3dc/0x3e8 > Sep 14 11:25:18 buildbot2 kernel: [85054.427411] [<ffffffff81508c7d>] ? > xen_start_kernel+0x57c/0x581 > Sep 14 11:25:18 buildbot2 kernel: [85054.427466] ---[ end trace > 9da64faa61cc18d7 ]--- > > > -- > Boris > > > -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part