* maximilian attems <m...@stro.at> [Sun Jul 11, 2010 at 06:13:15PM +0200]: > On Thu, 08 Jul 2010, Bastian Kleineidam wrote:
> > --- /usr/share/initramfs-tools/scripts/local-premount/resume~
> > 2010-07-07 23:13:20.000000000 +0200
> > +++ /usr/share/initramfs-tools/scripts/local-premount/resume
> > 2010-07-08 20:29:31.000000000 +0200
> > @@ -58,6 +58,13 @@
> > # hardcode path, uswsusp ships an resume binary too
> > if [ -n "${resume_offset}" ]; then
> > /bin/resume ${resume} ${resume_offset}
> > + res=$?
> > else
> > /bin/resume ${resume}
> > + res=$?
> > fi
> > +if [ $res -eq -1 ]; then
> > + # do not fail when falling back to normal boot
> > + exit 0
> > +fi
> > +exit $res
> checked indeed resume from klibc does return -1 when
> suspend doesn't happen.
> I haven't seen the resulting bootfailure yet, currently I can only
> explain it by noexec tmp and thus not precache run.
> the errexit for hooks on run_script() mika would thus also be hit
> on boot and not only on mkinitramfs. not sure that is what we want.
No, that's not we want - ack, we should fix that.
Exiting during buildtime, but trying to execute it on boot time
is what I'd consider as the way to go.
Thanks for catching, maks.
regards,
-mika-
signature.asc
Description: Digital signature
