I'm sorry, Laurie, but I didn't see this message from you in December. * Laurie Bradshaw <bradshaw.lau...@googlemail.com> [2008-12-23 04:29]: > The power LED isn't work correctly for a couple of reasons: > > 01_power_led_basic_fix.patch: > As the DNS-323 has two gpios for the power led, one must be set for > the other to operate as expected.
Can you please submit this patch to linux-arm-ker...@lists.arm.linux.org.uk > 02_power_led_blink_fix.patch: > Adds LED blink support for the DNS-323, and restores power led > default behaviour on boot (blinking should be stopped by userspace > after a successful boot). Hmm, do we really want to preserve this default? Anyway, the dns323_gpio_blink_set function should probably be in Orion generic code. Can you submit this to linux-arm-ker...@lists.arm.linux.org.uk too? > The following patches are for lm75 and g760a (temperature sensor and > fan control): > 03_enable_lm75_board_info.patch: > 04_lm75.patch: > Adds new style driver binding while also retaining old behaviour. It > looks like this is being fixed upstream, so this is only needed as a > temporary solution. I see this going into upstream... so this is no longer a problem with current kernels. I'm not sure we want to fix this for 2.6.26 in lenny since the second patch is quite large. (I considered putting these two patches into the kernel independently of your email but decided against it.) > 05_g760a.patch: > Adds support for the G760A fan speed controller. Right. Unfortunately, this driver isn't acceptable for upstream as it is and Herbert doesn't have time to clean it up. Matt made some changes to the patch but he never submitted it upstream. Would you consider submitting this or Matt's patch (which I can forward to you) upstream and make sure outstanding issues with it get resolved? > In addition, the following two patches would save rebuilding sata and > eth modules just to get the LEDs working right: > > 06_sata_mv_led.patch: > Current disk activity 'blinking' is barely distinguishable as > blinking without this patch, this makes the blinking more pronounced > as the original firmware did. > > 07_mv643xx_eth_led.patch: > More DNS-323 LED consistency. I'm pretty sure these are not acceptable. Can you please write an email to linux-arm-ker...@lists.arm.linux.org.uk and Mark Lord <l...@rtr.ca> describing what the problem is. Thanks. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
