On Thu, 18 Jan 2007 05:21:16 +0100, Willy Tarreau <[EMAIL PROTECTED]> wrote:
>Hi Grant ! > >On Thu, Jan 18, 2007 at 11:09:57AM +1100, Grant Coady wrote: >(...) >> > } else { >> >- mnt->file_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | >> >- S_IROTH | S_IXOTH | S_IFREG; >> >- mnt->dir_mode = mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | >> >- S_IROTH | S_IXOTH | S_IFDIR; >> >+ mnt->file_mode = S_IRWXU | S_IRGRP | S_IXGRP | >> >+ S_IROTH | S_IXOTH | S_IFREG | S_IFLNK; >> >+ mnt->dir_mode = S_IRWXU | S_IRGRP | S_IXGRP | >> >+ S_IROTH | S_IXOTH | S_IFDIR; >> > if (parse_options(mnt, raw_data)) >> > goto out_bad_option; >> >> I'm comparing 2.4.33.3 with 2.4.34, with 2.4.34 and above patch symlinks >> to directories seen as target, nor can they be created (Operation not >> permitted...) > >Thanks very much Grant for the test. Could you try a symlink to a file ? "Operation not permitted" >And while we're at it, would you like to try to add "|S_IFLNK" to >mnt->dir_mode ? If my suggestion was stupid, at least let's test it to >full extent ;-) Yep, already tried the obvious ;) no difference :( 2.4.33.5 onwards also have a problem with symlinks, but it is slightly different presentation, the directory symlinks appear as normal files. With 2.4.33.7 one is able to create file and directory symlinks, though the links appear as files. Content problem as noted by OP: [EMAIL PROTECTED]:/home/other$ uname -r 2.4.33.7 [EMAIL PROTECTED]:/home/other$ cat file this is a test [EMAIL PROTECTED]:/home/other$ cat filelink [EMAIL PROTECTED]:/home/other$ [EMAIL PROTECTED]:/home/other$ mkdir directory [EMAIL PROTECTED]:/home/other$ ln -s directory directorylink [EMAIL PROTECTED]:/home/other$ cp file* directory [EMAIL PROTECTED]:/home/other$ ls directory file* filelink* [EMAIL PROTECTED]:/home/other$ ls directorylink directorylink* Now, WinXP sees the contents of directorylink: X:\>cd directorylink X:\directorylink>dir Volume in drive X is other Volume Serial Number is 107E-052F Directory of X:\directorylink 2007-01-18 16:36 <DIR> . 2007-01-18 16:33 <DIR> .. 2007-01-18 16:36 15 file 2007-01-18 16:36 4 filelink 2 File(s) 19 bytes 2 Dir(s) 2,558,922,752 bytes free X:\directorylink>type file this is a test X:\directorylink>type filelink this X:\directorylink> > >I had another idea looking at the code but since I really don't know it, >I would not like to propose random changes till this magically works. I'd >wait for Dann who understood the code. Grant. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]